Skip to content

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Oct 6, 2025

Summary

Serialize and quantize automaticaly when possible. This make Ethos-U flows work.

Test plan

This is runned by the backed suit testing for Ethos-U

cc @freddan80 @per @oscarandersson8218 @digantdesai

…s-U flows

This make Ethos-U flows work.

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: Ib665857761f158b4a5b966d135ba335f28846109
@zingo zingo requested a review from cccclai as a code owner October 6, 2025 13:44
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm backend tester This bug was found by the backend test suite. labels Oct 6, 2025
Copy link

pytorch-bot bot commented Oct 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit aff7b55 with merge base 3557edf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@zingo zingo added release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 6, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@zingo zingo requested review from GregoryComer and digantdesai and removed request for cccclai October 6, 2025 14:21
kwargs["compile_spec"] = compile_spec
return ArmTester(*args, **kwargs)

support_serialize = not isinstance(compile_spec, TosaCompileSpec)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to run on tosa reference model, no?

Copy link
Collaborator Author

@zingo zingo Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have a "runner" for it. We only have a special testflow.
Enabling serilize right now causes more fails. Need to investigate more so I left it as a future exercise

)

ARM_ETHOS_U55_FLOW = _create_tosa_flow(
ARM_ETHOS_U55_FLOW = _create_arm_flow(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running the model won't this flow run into long runtime issues?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs kind of OK on my laptop, modeltest took about 30-40min I think. Lets see :)

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock, left some comments. Thanks @zingo !

@zingo zingo merged commit 8484aee into pytorch:main Oct 6, 2025
223 of 233 checks passed
@zingo zingo deleted the Arm-backend-Backend-test-serializes-and-uses-EthosUQuantizer-on-Ethos-U-flows branch October 7, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend tester This bug was found by the backend test suite. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants