-
Notifications
You must be signed in to change notification settings - Fork 680
Arm backend: Backend test serializes and uses EthosUQuant on Ethos-U flows #14817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zingo
merged 1 commit into
pytorch:main
from
zingo:Arm-backend-Backend-test-serializes-and-uses-EthosUQuantizer-on-Ethos-U-flows
Oct 6, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,70 +3,66 @@ | |
# This source code is licensed under the BSD-style license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
|
||
# Create flows for Arm Backends used to test operator and model suits | ||
|
||
from executorch.backends.arm.quantizer import ( | ||
get_symmetric_quantization_config, | ||
TOSAQuantizer, | ||
) | ||
from executorch.backends.arm.common.arm_compile_spec import ArmCompileSpec | ||
from executorch.backends.arm.quantizer import get_symmetric_quantization_config | ||
from executorch.backends.arm.test import common | ||
from executorch.backends.arm.test.tester.arm_tester import ArmTester | ||
from executorch.backends.arm.tosa.compile_spec import TosaCompileSpec | ||
from executorch.backends.arm.util._factory import create_quantizer | ||
from executorch.backends.test.suite.flow import TestFlow | ||
from executorch.backends.xnnpack.test.tester.tester import Quantize | ||
|
||
|
||
def _create_tosa_flow( | ||
def _create_arm_flow( | ||
name, | ||
compile_spec, | ||
quantize: bool = False, | ||
compile_spec: ArmCompileSpec, | ||
symmetric_io_quantization: bool = False, | ||
per_channel_quantization: bool = True, | ||
) -> TestFlow: | ||
|
||
def _create_arm_tester(*args, **kwargs) -> ArmTester: | ||
kwargs["compile_spec"] = compile_spec | ||
return ArmTester(*args, **kwargs) | ||
|
||
support_serialize = not isinstance(compile_spec, TosaCompileSpec) | ||
quantize = compile_spec.tosa_spec.support_integer() | ||
|
||
return ArmTester( | ||
*args, | ||
**kwargs, | ||
) | ||
if quantize is True: | ||
|
||
# Create and configure quantizer to use in the flow | ||
def create_quantize_stage() -> Quantize: | ||
quantizer = TOSAQuantizer(compile_spec) | ||
quantization_config = get_symmetric_quantization_config( | ||
is_per_channel=per_channel_quantization | ||
) | ||
if symmetric_io_quantization: | ||
quantizer.set_io(quantization_config) | ||
return Quantize(quantizer, quantization_config) | ||
def create_quantize_stage() -> Quantize: | ||
quantizer = create_quantizer(compile_spec) | ||
quantization_config = get_symmetric_quantization_config( | ||
is_per_channel=per_channel_quantization | ||
) | ||
if symmetric_io_quantization: | ||
quantizer.set_io(quantization_config) | ||
return Quantize(quantizer, quantization_config) | ||
|
||
return TestFlow( | ||
name, | ||
backend="arm", | ||
tester_factory=_create_arm_tester, | ||
supports_serialize=False, | ||
supports_serialize=support_serialize, | ||
quantize=quantize, | ||
quantize_stage_factory=create_quantize_stage if quantize else None, | ||
quantize_stage_factory=(create_quantize_stage if quantize is True else False), | ||
) | ||
|
||
|
||
ARM_TOSA_FP_FLOW = _create_tosa_flow( | ||
"arm_tosa_fp", common.get_tosa_compile_spec(tosa_spec="TOSA-1.0+FP") | ||
ARM_TOSA_FP_FLOW = _create_arm_flow( | ||
"arm_tosa_fp", | ||
common.get_tosa_compile_spec(tosa_spec="TOSA-1.0+FP"), | ||
) | ||
ARM_TOSA_INT_FLOW = _create_tosa_flow( | ||
ARM_TOSA_INT_FLOW = _create_arm_flow( | ||
"arm_tosa_int", | ||
common.get_tosa_compile_spec(tosa_spec="TOSA-1.0+INT"), | ||
quantize=True, | ||
) | ||
|
||
ARM_ETHOS_U55_FLOW = _create_tosa_flow( | ||
ARM_ETHOS_U55_FLOW = _create_arm_flow( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When running the model won't this flow run into long runtime issues? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. runs kind of OK on my laptop, modeltest took about 30-40min I think. Lets see :) |
||
"arm_ethos_u55", | ||
common.get_u55_compile_spec(), | ||
quantize=True, | ||
) | ||
|
||
ARM_ETHOS_U85_FLOW = _create_tosa_flow( | ||
ARM_ETHOS_U85_FLOW = _create_arm_flow( | ||
"arm_ethos_u85", | ||
common.get_u85_compile_spec(), | ||
quantize=True, | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to run on tosa reference model, no?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have a "runner" for it. We only have a special testflow.
Enabling serilize right now causes more fails. Need to investigate more so I left it as a future exercise