-
Notifications
You must be signed in to change notification settings - Fork 743
JNI support for multiple ptd files #14840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14840
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 Cancelled JobsAs of commit 505f466 with merge base e0dda90 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
54713e0 to
bb5db08
Compare
GregoryComer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the demo app build is failing on this PR. @kirklandsign @lucylq can you take a look? Thanks.
|
@lucylq curious how did it pass in main? |
|
@kirklandsign wondering if it's because when I CP'd this, the previous changes were not on the release branch. |
|
@GregoryComer likely have to rebase, we can also leave this out of the release branch and demo with the existing API. |
Thanks. I'll try to rebase. Since it was in the tracker prior and is limited to Android, I'm okay to merge today if we can get it passing, though I'll defer to your judgement. |
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14168 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/113/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/111/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/orig Differential Revision: [D82072929](https://our.internmc.facebook.com/intern/diff/D82072929/) @diff-train-skip-merge --------- Co-authored-by: lucylq <[email protected]> (cherry picked from commit 4d681cb)
bb5db08 to
505f466
Compare
|
if we pick this, also should pick this: #15067 |
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14168 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/113/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/111/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/orig
Differential Revision: D82072929
@diff-train-skip-merge