Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #14168 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/113/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/111/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/113/orig
Differential Revision: D82072929
@diff-train-skip-merge

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14840

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 Cancelled Jobs

As of commit 505f466 with merge base e0dda90 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025
@GregoryComer GregoryComer force-pushed the cherry-pick-14769-by-pytorch_bot_bot_ branch from 54713e0 to bb5db08 Compare October 7, 2025 21:36
Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the demo app build is failing on this PR. @kirklandsign @lucylq can you take a look? Thanks.

@kirklandsign
Copy link
Contributor

@lucylq curious how did it pass in main?

@lucylq
Copy link
Contributor

lucylq commented Oct 13, 2025

@kirklandsign wondering if it's because when I CP'd this, the previous changes were not on the release branch.

@lucylq
Copy link
Contributor

lucylq commented Oct 13, 2025

@GregoryComer likely have to rebase, we can also leave this out of the release branch and demo with the existing API.

@GregoryComer
Copy link
Member

@GregoryComer likely have to rebase, we can also leave this out of the release branch and demo with the existing API.

Thanks. I'll try to rebase. Since it was in the tracker prior and is limited to Android, I'm okay to merge today if we can get it passing, though I'll defer to your judgement.

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #14168 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/113/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/113/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/111/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/113/orig
Differential Revision:
[D82072929](https://our.internmc.facebook.com/intern/diff/D82072929/)
@diff-train-skip-merge

---------

Co-authored-by: lucylq <[email protected]>
(cherry picked from commit 4d681cb)
@GregoryComer GregoryComer force-pushed the cherry-pick-14769-by-pytorch_bot_bot_ branch from bb5db08 to 505f466 Compare October 13, 2025 20:41
@lucylq
Copy link
Contributor

lucylq commented Oct 14, 2025

if we pick this, also should pick this: #15067

@lucylq lucylq closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants