-
Notifications
You must be signed in to change notification settings - Fork 691
Arm backend: Add TOSA (DW) Conv2d dialect operator #14843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Add TOSA (DW) Conv2d dialect operator #14843
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14843
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit d5b8630 with merge base a33e91f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
26268d0
to
98d31d8
Compare
from executorch.backends.arm.tosa.specification import Tosa_1_00, TosaSpecification | ||
from executorch.backends.arm.tosa.utils import tosa_shape | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rename :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like this tosa op abstraction layer direction :)
Adds backend dialect operators for: - Conv2D - Depthwise Conv2D Also removes AddBiasPass and moves that logic to new RewriteConv2dPass. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I1185f51ded5e931ca042f445934cd21e20fdf469
89af054
to
d5b8630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial changes since approval that should not have an impact on buck2.
CI failures unrelated.
Adds backend dialect operators for:
Also removes AddBiasPass and moves that logic to new RewriteConv2dPass.
cc @freddan80 @per @zingo @digantdesai