Skip to content

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Oct 7, 2025

Adds backend dialect operators for:

  • Conv2D
  • Depthwise Conv2D

Also removes AddBiasPass and moves that logic to new RewriteConv2dPass.

cc @freddan80 @per @zingo @digantdesai

Copy link

pytorch-bot bot commented Oct 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14843

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit d5b8630 with merge base a33e91f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025
@oscarandersson8218 oscarandersson8218 added ciflow/trunk module: arm Issues related to arm backend release notes: none Do not include this in the release notes partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm and removed module: arm Issues related to arm backend labels Oct 7, 2025
from executorch.backends.arm.tosa.specification import Tosa_1_00, TosaSpecification
from executorch.backends.arm.tosa.utils import tosa_shape


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rename :)

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like this tosa op abstraction layer direction :)

Adds backend dialect operators for:
- Conv2D
- Depthwise Conv2D

Also removes AddBiasPass and moves that logic to new RewriteConv2dPass.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I1185f51ded5e931ca042f445934cd21e20fdf469
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial changes since approval that should not have an impact on buck2.

CI failures unrelated.

@Sebastian-Larsson Sebastian-Larsson merged commit f995ff7 into pytorch:main Oct 17, 2025
288 of 291 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants