Arm backend: Add recipe infrastructure #14849

Erik-Lundell · 2025-10-07T12:05:03Z

Recipes were introduced with issue #12248 to simplify the ET api for new users. A backend introduces standard recipes with partitioner and quantizer configuration, and possibly passes.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

pytorch-bot · 2025-10-07T12:05:07Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14849

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 224d8d4 with merge base 8fbc42c ():

NEW FAILURES - The following jobs have failed:

pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 5bb58ad38bea0aed750bc47d763adfdf43e393b8ae1568fb2384db6ae3895bad /exec failed with exit code 1
Test CUDA Builds / test-voxtral-cuda-e2e / linux-job (gh)
RuntimeError: Command docker exec -t a1ecd0a2798172ad8d373ac8c787d7a4848a2dec67872b3c9d2390c820727540 /exec failed with exit code 2
trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (gh)
RuntimeError: Command docker exec -t 231287d3ffb3b059f93f51264eb6c9e3f170c008da1c529b14c5146948ad77c3 /exec failed with exit code 1
trunk / test-arm-cortex-m-size-test (zephyr-preset) / linux-job (gh)
RuntimeError: Command docker exec -t 3d5814a988971f911445af57faa3f34dcebb57fb4407a4d2fd8cf02b06093808 /exec failed with exit code 1
trunk / unittest-release / linux / linux-job (gh)
examples/models/test/test_export.py::ExportTest::test_mv3_export_to_executorch

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Apple / build-demo-ios / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 74

This comment was automatically generated by Dr. CI and updates every 15 minutes.

abhinaykukkadapu · 2025-10-08T16:10:34Z

backends/arm/recipe/arm_recipe_provider.py

+    quantizer.set_global(get_symmetric_quantization_config(is_per_channel=False))
+
+
+class ArmRecipeProvider(BackendRecipeProvider):


Looks great, thanks for adding these recipes, is it possible to add a couple of model tests using any of these recipes, just to make sure?

Thanks, I plan on adding tests using recipes in an upcoming patch.

abhinaykukkadapu · 2025-10-08T16:12:11Z

backends/arm/recipe/arm_recipe_provider.py

+                recipe_type,
+                TargetRecipe(common.get_tosa_compile_spec("TOSA-1.0+FP", **kwargs)),
+            )
+        case ArmRecipeType.TOSA_INT8_STATIC_PER_TENSOR:


Do we need any kwarg validation, to let user know if they've configured the recipes wrong?

Good idea, will do that in an upcoming patch.

abhinaykukkadapu

Have minor comments,

Recipes were introduced with issue pytorch#12248 to simplify the ET api for new users. A backend introduces standard recipes with partitioner and quantizer configuration, and possibly passes. In addition to the benefits of integrating with existing infra, the arm backend can benefit from the recipe structure as a test-framework-agnostic way of defining how a tested model should be lowered. Additonally, it ties into simplifying the aot_arm_compiler interface. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Iebd3f101f94a3df657af3b49ea563f72cbca3a9a

Dry coded with AI, needs verification Signed-off-by: Erik Lundell <[email protected]> Change-Id: I79d3009c5bc6557601cab9501f2e275f89c95330

digantdesai · 2025-10-13T16:59:53Z

backends/arm/recipe/arm_recipe_provider.py

+                [global_int8_per_channel],
+            )
+
+        case ArmRecipeType.VGF_FP:


Nit

Suggested change

case ArmRecipeType.VGF_FP:

case ArmRecipeType.VGF_FP32:

digantdesai · 2025-10-13T17:01:17Z

backends/arm/recipe/arm_recipe_types.py

+    """
+    ETHOSU_U55_INT8_STATIC_PER_CHANNEL = "arm_ethosu_u55_int_static_per_channel"
+    """ Kwargs:
+            - macs: int = 128,


do we need these comments? I am afraid they will get out of sync without being tested.. we should have this in validation as you are planning..

digantdesai · 2025-10-13T17:02:16Z

backends/arm/recipe/recipe.py

+    edge_transform_passes: List[PassType] = field(default_factory=lambda: [])
+
+
+class ArmExportRecipe(ExportRecipe):


add at least a basic test to make this PR self containing..

meta-codesync · 2025-10-13T17:09:36Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D84517727.

Erik-Lundell requested a review from digantdesai as a code owner October 7, 2025 12:05

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2025

Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 7, 2025

mergennachin requested a review from abhinaykukkadapu October 8, 2025 13:11

abhinaykukkadapu reviewed Oct 8, 2025

View reviewed changes

abhinaykukkadapu approved these changes Oct 8, 2025

View reviewed changes

Erik-Lundell added 2 commits October 9, 2025 10:27

Arm backend: add buck file for recipe folder.

224d8d4

Dry coded with AI, needs verification Signed-off-by: Erik Lundell <[email protected]> Change-Id: I79d3009c5bc6557601cab9501f2e275f89c95330

Erik-Lundell force-pushed the recipe-infra branch from a8b1cfc to 224d8d4 Compare October 9, 2025 10:51

digantdesai reviewed Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Arm backend: Add recipe infrastructure #14849

Arm backend: Add recipe infrastructure #14849

Uh oh!

Erik-Lundell commented Oct 7, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

abhinaykukkadapu Oct 8, 2025

Uh oh!

Erik-Lundell Oct 9, 2025

Uh oh!

abhinaykukkadapu Oct 8, 2025

Uh oh!

Erik-Lundell Oct 9, 2025

Uh oh!

abhinaykukkadapu left a comment

Uh oh!

digantdesai Oct 13, 2025

Uh oh!

digantdesai Oct 13, 2025

Uh oh!

digantdesai Oct 13, 2025

Uh oh!

meta-codesync bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		quantizer.set_global(get_symmetric_quantization_config(is_per_channel=False))


		class ArmRecipeProvider(BackendRecipeProvider):

		edge_transform_passes: List[PassType] = field(default_factory=lambda: [])


		class ArmExportRecipe(ExportRecipe):

Arm backend: Add recipe infrastructure #14849

Are you sure you want to change the base?

Arm backend: Add recipe infrastructure #14849

Uh oh!

Conversation

Erik-Lundell commented Oct 7, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14849

❌ 5 New Failures, 1 Unrelated Failure

Uh oh!

abhinaykukkadapu Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Erik-Lundell Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

abhinaykukkadapu Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Erik-Lundell Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

abhinaykukkadapu left a comment

Choose a reason for hiding this comment

Uh oh!

digantdesai Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

meta-codesync bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Erik-Lundell commented Oct 7, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 7, 2025 •

edited

Loading