Introduce public MergedDataMap #14861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucylq
requested review from
GregoryComer,
SS-JIA,
cccclai,
kirklandsign,
larryliu0820 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14861
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 64b0045 with merge base 0bfb61e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
swolchok
approved these changes
Oct 7, 2025
Summary: Pull Request resolved: pytorch#14861 Add public merged data map. Module can use this to resolve multiple named data maps. Creating as a sep dependency rather than inside module/ so it can be used independently of module. (think there may be some other internal usages soon) Add support for BUCK and CMake. On CMake side, have to add the dep for everyone who uses module .. Reviewed By: swolchok Differential Revision: D83527299
lucylq
force-pushed
the
export-D83527299
branch
from
f748684 to
64b0045
Compare
GregoryComer
approved these changes
Oct 7, 2025
Erik-Lundell
added a commit
to Erik-Lundell/executorch
that referenced
this pull request
Oct 8, 2025
PR pytorch#14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I34f7cc989e7369883b353d96ccb262b43062a82f
zingo
pushed a commit
that referenced
this pull request
Oct 8, 2025
PR #14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. Signed-off-by: Erik Lundell <[email protected]>
larryliu0820
added a commit
that referenced
this pull request
Oct 8, 2025
Since #14861 we need to specify `EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP=ON` along with `EXECUTORCH_BUILD_EXTENSION_MODULE=ON`. Adding that.
larryliu0820
added a commit
that referenced
this pull request
Oct 8, 2025
Since #14861 we need to specify `EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP=ON` along with `EXECUTORCH_BUILD_EXTENSION_MODULE=ON`. Adding that to fix CUDA CI.
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Cherry picking #14861The cherry pick PR is at #14899 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 8, 2025
PR #14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. Signed-off-by: Erik Lundell <[email protected]> (cherry picked from commit 45bf018)
GregoryComer
pushed a commit
that referenced
this pull request
Oct 9, 2025
PR #14861 and #14899 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Erik Lundell <[email protected]> Co-authored-by: Erik Lundell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add public merged data map. Module can use this to resolve multiple named data maps.
Creating as a sep dependency rather than inside module/ so it can be used independently of module. (think there may be some other internal usages soon)
Add support for BUCK and CMake. On CMake side, have to add the dep for everyone who uses module ..
Reviewed By: swolchok
Differential Revision: D83527299