Arm backend: Support min/max with unset dim. #14894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dim is defined as optional, but before the pass requried it to be set. When it is not set, the operation should be done on all dims. Signed-off-by: Erik Lundell <[email protected]> (cherry picked from commit 9be3aaa)
This was referenced Oct 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14894
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 Cancelled JobsAs of commit ef66479 with merge base e0dda90 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
GregoryComer
approved these changes
Oct 8, 2025
Collaborator
|
Lets ignore for 1.0 |
Contributor
|
Should we try and fix the linter issue? Or you have another PR to cherry-pick @zingo? |
Collaborator
|
This was a nice to get fixed as we have a fix, and not anything urgent. Will happy have the fix in 1.1 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dim is defined as optional, but before the pass requried it to be set. When it is not set, the operation should be done on all dims.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai