Skip to content

refactor cuda_backend.cpp #14904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2025
Merged

refactor cuda_backend.cpp #14904

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59a20ff
refactor cuda_backend.cpp
Gasoonjia Oct 8, 2025
f7292fe
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
8361ceb
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
202fb2a
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
f1c35bf
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
4021d39
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
ec87078
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
f60bb93
Update on "refactor cuda_backend.cpp"
Gasoonjia Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 68 additions & 107 deletions backends/cuda/runtime/cuda_backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ namespace executorch {
namespace backends {
namespace cuda {

#define LOAD_SYMBOL(name, handle) \
do { \
name = reinterpret_cast<name##Func>(dlsym(handle, #name)); \
ET_CHECK_OR_RETURN_ERROR( \
name != nullptr, AccessFailed, "Failed to load " #name); \
} while (0)

using namespace std;
using namespace aoti;

Expand All @@ -53,45 +60,11 @@ class ET_EXPERIMENTAL CudaBackend final
: public ::executorch::runtime::BackendInterface {
private:
Error register_shared_library_functions(void* so_handle) const {
AOTInductorModelContainerCreateWithDevice =
reinterpret_cast<AOTInductorModelContainerCreateWithDeviceFunc>(
dlsym(so_handle, "AOTInductorModelContainerCreateWithDevice"));
if (AOTInductorModelContainerCreateWithDevice == nullptr) {
ET_LOG(Error, "Failed to load AOTInductorModelContainerCreateWithDevice");
return Error::AccessFailed;
}

AOTInductorModelContainerDelete =
reinterpret_cast<AOTInductorModelContainerDeleteFunc>(
dlsym(so_handle, "AOTInductorModelContainerDelete"));
if (AOTInductorModelContainerDelete == nullptr) {
ET_LOG(Error, "Failed to load AOTInductorModelContainerDelete");
return Error::AccessFailed;
}

AOTInductorModelContainerGetNumInputs =
reinterpret_cast<AOTInductorModelContainerGetNumInputsFunc>(
dlsym(so_handle, "AOTInductorModelContainerGetNumInputs"));
if (AOTInductorModelContainerGetNumInputs == nullptr) {
ET_LOG(Error, "Failed to load AOTInductorModelContainerGetNumInputs");
return Error::AccessFailed;
}

AOTInductorModelContainerGetNumOutputs =
reinterpret_cast<AOTInductorModelContainerGetNumOutputsFunc>(
dlsym(so_handle, "AOTInductorModelContainerGetNumOutputs"));
if (AOTInductorModelContainerGetNumOutputs == nullptr) {
ET_LOG(Error, "Failed to load AOTInductorModelContainerGetNumOutputs");
return Error::AccessFailed;
}

AOTInductorModelContainerRun =
reinterpret_cast<AOTInductorModelContainerRunFunc>(
dlsym(so_handle, "AOTInductorModelContainerRun"));
if (AOTInductorModelContainerRun == nullptr) {
ET_LOG(Error, "Failed to load AOTInductorModelContainerRun");
return Error::AccessFailed;
}
LOAD_SYMBOL(AOTInductorModelContainerCreateWithDevice, so_handle);
LOAD_SYMBOL(AOTInductorModelContainerDelete, so_handle);
LOAD_SYMBOL(AOTInductorModelContainerGetNumInputs, so_handle);
LOAD_SYMBOL(AOTInductorModelContainerGetNumOutputs, so_handle);
LOAD_SYMBOL(AOTInductorModelContainerRun, so_handle);

return Error::Ok;
}
Expand Down Expand Up @@ -122,14 +95,13 @@ class ET_EXPERIMENTAL CudaBackend final

const NamedDataMap* named_data_map = context.get_named_data_map();
auto aoti_cuda_buffer = named_data_map->get_data(so_blob_key.c_str());
if (!aoti_cuda_buffer.ok()) {
ET_LOG(
Error,
"Failed to get data for key %s: 0x%x",
so_blob_key.c_str(),
aoti_cuda_buffer.error());
return aoti_cuda_buffer.error();
}
ET_CHECK_OR_RETURN_ERROR(
aoti_cuda_buffer.ok(),
aoti_cuda_buffer.error(),
Copy link
Contributor

@larryliu0820 larryliu0820 Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed to compile because it's returning a AOTI error not a ET error

"Failed to get data for key %s: 0x%x",
so_blob_key.c_str(),
aoti_cuda_buffer.error());

// Generate dynamic temporary file path
filesystem::path temp_dir = filesystem::temp_directory_path();
filesystem::path so_path =
Expand All @@ -144,39 +116,35 @@ class ET_EXPERIMENTAL CudaBackend final
"Writing %zu bytes to %s",
aoti_cuda_buffer->size(),
so_path.c_str());

outfile.write(
static_cast<const char*>(aoti_cuda_buffer->data()),
aoti_cuda_buffer->size());

if (!outfile) {
ET_LOG(Error, "Failed to write to file %s", so_path.c_str());
return Error::AccessFailed;
}
ET_CHECK_OR_RETURN_ERROR(
outfile, AccessFailed, "Failed to write to file %s", so_path.c_str());

// Finish writing the file to disk
outfile.close();

// Load the ELF using dlopen
void* so_handle = dlopen(so_path.c_str(), RTLD_LAZY | RTLD_LOCAL);
if (so_handle == nullptr) {
ET_LOG(Error, "Failed to load shared library: %s", dlerror());
return Error::AccessFailed;
}
ET_CHECK_OR_RETURN_ERROR(
so_handle != nullptr,
AccessFailed,
"Failed to load shared library: %s",
dlerror());

processed->Free();

// Register all shared library functions
Error reg_err = register_shared_library_functions(so_handle);
if (reg_err != Error::Ok) {
return reg_err;
}
ET_CHECK_OK_OR_RETURN_ERROR(register_shared_library_functions(so_handle));

AOTInductorModelContainerHandle container_handle = nullptr;

AOTIRuntimeError err = AOTInductorModelContainerCreateWithDevice(
&container_handle, 1, "cuda", nullptr);
if (err != Error::Ok) {
return err;
}
ET_CHECK_OK_OR_RETURN_ERROR(AOTInductorModelContainerCreateWithDevice(
&container_handle, 1, "cuda", nullptr));

ET_LOG(Info, "container_handle = %p", container_handle);

AOTIDelegateHandle* handle = new AOTIDelegateHandle();
Expand Down Expand Up @@ -206,15 +174,13 @@ class ET_EXPERIMENTAL CudaBackend final
AOTInductorModelContainerGetNumOutputs(
handle->container_handle, &n_outputs);

if (n_inputs + n_outputs != args.size()) {
ET_LOG(
Error,
"number of user input %zd and output %zd generated from AOT Inductor does not match ET runner's %zd. Exit.",
n_inputs,
n_outputs,
args.size());
return Error::InvalidArgument;
}
ET_CHECK_OR_RETURN_ERROR(
n_inputs + n_outputs == args.size(),
InvalidArgument,
"number of user input %zd and output %zd generated from AOT Inductor does not match ET runner's %zd. Exit.",
n_inputs,
n_outputs,
args.size())

// NOTE: ExecuTorch tensors are always on CPU/host memory
// We need to create GPU copies for CUDA kernel execution
Expand Down Expand Up @@ -244,19 +210,20 @@ class ET_EXPERIMENTAL CudaBackend final
0, // device_index = 0
&gpu_input_handle);

if (create_err != Error::Ok) {
ET_LOG(Error, "Failed to create GPU tensor for input %d", i);
return Error::Internal;
}
ET_CHECK_OR_RETURN_ERROR(
create_err == Error::Ok,
Internal,
"Failed to create GPU tensor for input %d",
i);

gpu_inputs[i] = gpu_input_handle;

// Copy data from CPU to GPU
Error copy_err = aoti_torch_copy_(gpu_inputs[i], cpu_tensor, 0);
if (copy_err != Error::Ok) {
ET_LOG(Error, "Failed to copy input %d from CPU to GPU", i);
return Error::Internal;
}
ET_CHECK_OR_RETURN_ERROR(
aoti_torch_copy_(gpu_inputs[i], cpu_tensor, 0) == Error::Ok,
Internal,
"Failed to copy input %d from CPU to GPU",
i);
}
ET_LOG(Info, "Inputs copied to GPU");
// Process output tensors: create GPU counterparts for ExecuTorch CPU
Expand All @@ -280,10 +247,11 @@ class ET_EXPERIMENTAL CudaBackend final
0, // device_index = 0
&gpu_output_handle);

if (create_err != Error::Ok) {
ET_LOG(Error, "Failed to create GPU tensor for output %d", i);
return Error::Internal;
}
ET_CHECK_OR_RETURN_ERROR(
create_err == Error::Ok,
Internal,
"Failed to create GPU tensor for output %d",
i);

gpu_outputs[i] = gpu_output_handle;
}
Expand All @@ -298,13 +266,11 @@ class ET_EXPERIMENTAL CudaBackend final
handle->cuda_stream, // Pass the actual CUDA stream
nullptr); // proxy_executor_handle can remain nullptr

if (error != Error::Ok) {
ET_LOG(
Error,
"AOTInductorModelContainerRun failed with error code %d",
error);
return Error::Internal;
}
ET_CHECK_OR_RETURN_ERROR(
error == Error::Ok,
Internal,
"AOTInductorModelContainerRun failed with error code %d",
error);

// Copy GPU output results back to CPU output tensors
for (int i = 0; i < n_outputs; i++) {
Expand Down Expand Up @@ -356,12 +322,10 @@ class ET_EXPERIMENTAL CudaBackend final
if (handle->container_handle != nullptr) {
AOTIRuntimeError delete_result =
AOTInductorModelContainerDelete(handle->container_handle);
if (delete_result != Error::Ok) {
ET_LOG(
Error,
"AOTInductorModelContainerDelete failed with error code %d",
delete_result);
}
ET_CHECK_OR_LOG(
delete_result == Error::Ok,
"Failed to delete AOTInductorModelContainer with error code %d",
delete_result);
handle->container_handle = nullptr;
}

Expand All @@ -373,14 +337,11 @@ class ET_EXPERIMENTAL CudaBackend final
// Remove the temporary shared library file
if (!handle->so_path.empty()) {
std::error_code remove_error;
std::filesystem::remove(handle->so_path, remove_error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete this line

if (remove_error) {
ET_LOG(
Error,
"Failed to remove temporary shared library %s: %s",
handle->so_path.c_str(),
remove_error.message().c_str());
}
ET_CHECK_OR_LOG(
!remove_error,
"Failed to remove temporary shared library %s: %s",
handle->so_path.c_str(),
remove_error.message().c_str())
}

delete handle;
Expand Down
Loading