Skip to content

Arm backend: Add support for floor_divide.default #14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zingo merged 1 commit into from
Oct 30, 2025
Merged

Arm backend: Add support for floor_divide.default #14933

zingo merged 1 commit into from
Oct 30, 2025

Conversation

@agrima1304
Copy link
Collaborator

@agrima1304 agrima1304 commented Oct 9, 2025 •
edited by pytorch-bot bot
Loading

Converts floor_divide.default to div.Tensor_mode with rounding_mode = "floor"

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@agrima1304 agrima1304 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14933

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 2 Pending, 2 Unrelated Failures

As of commit fe66114 with merge base 9d68039 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 12, 2025

Hi I see some testfails in backends/arm/test/ops/test_floor_div.py::test_floor_divide*
https://github.com/pytorch/executorch/actions/runs/18406911009/job/52448990081?pr=14933

digantdesai
digantdesai reviewed Oct 13, 2025
View reviewed changes
backends/arm/_passes/decompose_floor_divide_pass.py
input = args[0]
other = args[1]

div_node = super().call_operator(
Copy link
Contributor

@digantdesai digantdesai Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@agrima1304
Copy link
Collaborator Author

agrima1304 commented Oct 15, 2025

Hi I see some testfails in backends/arm/test/ops/test_floor_div.py::test_floor_divide* https://github.com/pytorch/executorch/actions/runs/18406911009/job/52448990081?pr=14933

I am working on fixes for the failures 👍

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

Stil had Arm job fails, since it has not been runned it a while I rebased it. Lets see if it work and Arm tests works now.

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

Added files should be covered where needed with a *.py already for buck2

@agrima1304
Arm backend: Add support for floor_divide.default
fe66114 
Signed-off-by: Agrima Khare <[email protected]>
Change-Id: If8ff03bedda35b60959c436111922033a35af7c1
@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

Fails are unrelated

@zingo zingo merged commit c0df044 into pytorch:main Oct 30, 2025
295 of 298 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agrima1304 @zingo @digantdesai