Skip to content

Conversation

agrima1304
Copy link
Collaborator

@agrima1304 agrima1304 commented Oct 9, 2025

Converts floor_divide.default to div.Tensor_mode with rounding_mode = "floor"

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Signed-off-by: Agrima Khare <[email protected]>
Change-Id: I85153b1b245862a107e6469600e69c059477f417
@agrima1304 agrima1304 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 9, 2025
Copy link

pytorch-bot bot commented Oct 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14933

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 9 New Failures, 1 Cancelled Job, 10 Unrelated Failures

As of commit e05b531 with merge base ef21739 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
agrima1304 and others added 2 commits October 10, 2025 13:40
Signed-off-by: Agrima Khare <[email protected]>
Change-Id: I85153b1b245862a107e6469600e69c059477f417
@zingo
Copy link
Collaborator

zingo commented Oct 12, 2025

Hi I see some testfails in backends/arm/test/ops/test_floor_div.py::test_floor_divide*
https://github.com/pytorch/executorch/actions/runs/18406911009/job/52448990081?pr=14933

input = args[0]
other = args[1]

div_node = super().call_operator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@agrima1304
Copy link
Collaborator Author

Hi I see some testfails in backends/arm/test/ops/test_floor_div.py::test_floor_divide* https://github.com/pytorch/executorch/actions/runs/18406911009/job/52448990081?pr=14933

I am working on fixes for the failures 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants