Skip to content

Update derived_zero initialization to use device aligned with other i… #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2025
Merged

Update derived_zero initialization to use device aligned with other i… #14978

merged 2 commits into from
Oct 14, 2025

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Oct 10, 2025 •
edited
Loading

Run into issues when trying to use GPU to quantize the model. Fix the device type for zero point. The log was like

input.device.type cuda  scales.device.type cuda  zero_points.device.type cpu

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14978

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 121 Pending

As of commit ab8d4e7 with merge base d39992f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai merged commit 71bbb1b into main Oct 14, 2025
125 of 132 checks passed
@cccclai cccclai deleted the cccclai-patch-4 branch October 14, 2025 00:18
Gasoonjia pushed a commit that referenced this pull request Oct 14, 2025
@cccclai @Gasoonjia
Update derived_zero initialization to use device aligned with other i… (
b68ee33 
#14978)

Run into issues when trying to use GPU to quantize the model. Fix the
device type for zero point. The log was like
```
input.device.type cuda  scales.device.type cuda  zero_points.device.type cpu
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

+2 more reviewers

@haowhsu-quic haowhsu-quic haowhsu-quic approved these changes

@chenweng-quic chenweng-quic chenweng-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cccclai @mergennachin @haowhsu-quic @chenweng-quic