-
Notifications
You must be signed in to change notification settings - Fork 698
Add a precommit hook to automatically update .ci/docker/ci_commit_pins/pytorch.txt when torch_pin.py is changed. #15072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15072
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 3 Cancelled Jobs, 13 Pending, 3 Unrelated FailuresAs of commit a4f8fee with merge base 481c9cf ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -0,0 +1,57 @@ | |||
| # Git Hooks | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this line or the whole file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like it is helpful. Developers will have to do some manual install to enable this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! I can get rid of my CI #15070
…s/pytorch.txt when torch_pin.py is changed. (#15072) This pull request introduces a new script, `.github/scripts/update_pytorch_pin.py`, which automates the process of updating the PyTorch commit pin based on the nightly version specified in `torch_pin.py`. The script parses the nightly version, fetches the corresponding commit hash from the PyTorch nightly branch using the GitHub API, and updates the pin file accordingly. This automation helps ensure that the CI environment uses the correct nightly commit for PyTorch. Automation of PyTorch nightly pin updating: * Added `.github/scripts/update_pytorch_pin.py`, a script that reads the nightly version from `torch_pin.py`, parses the date, fetches the corresponding commit hash from the PyTorch nightly branch via the GitHub API, and updates `.ci/docker/ci_commit_pins/pytorch.txt` with the new hash. Test plan: Run `.githooks/install.sh` Tested manually by changing `NIGHTLY_VERSION` and try to commit locally. Was able to see `.ci/docker/ci_commit_pins/pytorch.txt` being updated.
This pull request introduces a new script,
.github/scripts/update_pytorch_pin.py, which automates the process of updating the PyTorch commit pin based on the nightly version specified intorch_pin.py. The script parses the nightly version, fetches the corresponding commit hash from the PyTorch nightly branch using the GitHub API, and updates the pin file accordingly. This automation helps ensure that the CI environment uses the correct nightly commit for PyTorch.Automation of PyTorch nightly pin updating:
.github/scripts/update_pytorch_pin.py, a script that reads the nightly version fromtorch_pin.py, parses the date, fetches the corresponding commit hash from the PyTorch nightly branch via the GitHub API, and updates.ci/docker/ci_commit_pins/pytorch.txtwith the new hash.Test plan:
Run
.githooks/install.shTested manually by changing
NIGHTLY_VERSIONand try to commit locally. Was able to see.ci/docker/ci_commit_pins/pytorch.txtbeing updated.