Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

Summary:
CMake and Doc Updates for Bundled Program

This diff includes the following changes:

Doc Updates

  • Updated bundled-io.md to reflect changes in the getting-started and export-to-executorch-tutorial links.

CMake Updates

  • Updated build_example_runner.sh to simplify the build process and fix the pipefail issue.
  • Updated test_example_runner.sh to use the same build script as build_example_runner.sh and remove redundant code.

Reviewed By: larryliu0820, lucylq

Differential Revision: D84526104

Summary:
**CMake and Doc Updates for Bundled Program**
==============================================

This diff includes the following changes:

### Doc Updates

* Updated `bundled-io.md` to reflect changes in the `getting-started` and `export-to-executorch-tutorial` links.

### CMake Updates

* Updated `build_example_runner.sh` to simplify the build process and fix the pipefail issue.
* Updated `test_example_runner.sh` to use the same build script as `build_example_runner.sh` and remove redundant code.

Reviewed By: larryliu0820, lucylq

Differential Revision: D84526104
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15081

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 3 Pending, 2 Unrelated Failures

As of commit e78d966 with merge base d382f6b (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 13, 2025

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84526104.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit dbd0e9f into main Oct 14, 2025
139 of 151 checks passed
@meta-codesync meta-codesync bot deleted the export-D84526104 branch October 14, 2025 04:07
@Gasoonjia
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 14, 2025
Differential Revision: D84526104

Pull Request resolved: #15081

(cherry picked from commit dbd0e9f)
@pytorchbot
Copy link
Collaborator

Cherry picking #15081

The cherry pick PR is at #15093 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Gasoonjia added a commit that referenced this pull request Oct 14, 2025
Differential Revision: D84526104

Pull Request resolved: #15081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants