-
Notifications
You must be signed in to change notification settings - Fork 752
Cortex_m backend: Fix add implementation #15100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Call CMSIS-NN kernel with correct argument order and signs - Change python implementation to reflect CMSIS-NN behaviour - Fix scale calculations - Remove broken broadcasting support - Add pass to lower scalar version ops - Remove unused definitions/ implementations in operators.py, operators.yaml and op_quantized_add.cpp Note: arm_elementwise_add_s8 does not natively support broadcasting, so simply resizing the output tensor will not work. Enabling this in an efficient way is not stragiht forward, so avoid fusing these ops for now to avoid break graphs. Signed-off-by: Adrian Lundell <[email protected]> Change-Id: Id76db13848f2ce67d7527f40d31c06db663af8fa
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15100
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 61dddb5 with merge base 5426918 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Adrian Lundell <[email protected]>
|
It looks like the test-mcu-models (cmake) / linux-job CI job has been failing since this PR merged. Example failure: https://github.com/pytorch/executorch/actions/runs/18869591982/job/53844591126. Can you take a look? Thanks. |
|
We should remove that test IMO, it was only testing the lowering and not that we were getting reasonable results, and we have pytests which covers that now. I can create a patch for that today. |
Note: arm_elementwise_add_s8 does not natively support broadcasting, so simply resizing the output tensor will not work. Enabling this in an efficient way is not straight forward, so avoid fusing these ops for now to avoid break graphs.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai