Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Oct 14, 2025

  • Call CMSIS-NN kernel with correct argument order and signs
  • Change python implementation to reflect CMSIS-NN behaviour
  • Fix scale calculations
  • Remove broken broadcasting support
  • Add pass to lower scalar version ops
  • Remove unused definitions/ implementations in operators.py, operators.yaml and op_quantized_add.cpp

Note: arm_elementwise_add_s8 does not natively support broadcasting, so simply resizing the output tensor will not work. Enabling this in an efficient way is not straight forward, so avoid fusing these ops for now to avoid break graphs.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

- Call CMSIS-NN kernel with correct argument order and signs
- Change python implementation to reflect CMSIS-NN behaviour
- Fix scale calculations
- Remove broken broadcasting support
- Add pass to lower scalar version ops
- Remove unused definitions/ implementations in operators.py,
  operators.yaml and op_quantized_add.cpp

Note: arm_elementwise_add_s8 does not natively support broadcasting,
so simply resizing the output tensor will not work. Enabling this
in an efficient way is not stragiht forward, so avoid fusing these
ops for now to avoid break graphs.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Id76db13848f2ce67d7527f40d31c06db663af8fa
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15100

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 61dddb5 with merge base 5426918 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
@AdrianLundell AdrianLundell added release notes: none Do not include this in the release notes partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm labels Oct 14, 2025
@AdrianLundell AdrianLundell merged commit 0e18b9f into pytorch:main Oct 28, 2025
140 of 144 checks passed
@GregoryComer
Copy link
Member

It looks like the test-mcu-models (cmake) / linux-job CI job has been failing since this PR merged. Example failure: https://github.com/pytorch/executorch/actions/runs/18869591982/job/53844591126. Can you take a look? Thanks.
CC @AdrianLundell @psiddh

@AdrianLundell
Copy link
Collaborator Author

We should remove that test IMO, it was only testing the lowering and not that we were getting reasonable results, and we have pytests which covers that now. I can create a patch for that today.

@AdrianLundell AdrianLundell deleted the change-1105490 branch November 7, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants