Skip to content

Switch ruamel-yaml default from 0.17.x to 0.18.15 #15119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Switch ruamel-yaml default from 0.17.x to 0.18.15 #15119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/docker/requirements-ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
mpmath==1.3.0
numpy>=2.0.0; python_version >= '3.10'
PyYAML==6.0.1
ruamel.yaml==0.17.32
ruamel.yaml==0.18.15
sympy==1.12
timm==0.6.13
tomli==2.0.1
Expand Down
2 changes: 0 additions & 2 deletions exir/dialects/edge/_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from executorch.exir.dialects.edge.op.api import to_variant
from executorch.exir.dialects.edge.spec.utils import get_tensor_variable_names

# pyre-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing these pyre-ignores?

Copy link
Contributor Author

@mkillianey mkillianey Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type information was not available in ruamel 0.17.x, but is in 0.18.15. (I.e., the linter complained that this directive is no longer necessary after upgrading the package)

from ruamel.yaml import YAML
from torchgen.model import SchemaKind

Expand Down Expand Up @@ -166,7 +165,6 @@ def __getitem__(self, arg_name: str) -> Set[torch.dtype]:


def _load_edge_dialect_info() -> Dict[str, Dict[str, Any]]:
# pyre-ignore
yaml = YAML(typ="safe")
edge_yaml = resources.read_text(edge_package, "edge.yaml", encoding="utf-8")
edge_dialect_yaml_info = yaml.load(edge_yaml)
Expand Down
1 change: 0 additions & 1 deletion exir/dialects/edge/spec/gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
op.aten_name if op.aten_name is not None else op.name: op for op in op_db
}

# pyre-ignore
yaml = ruamel.yaml.YAML()

dtr = DtypeRunner()
Expand Down
Loading