Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Oct 15, 2025

Stack from ghstack (oldest at bottom):

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: D84716454

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15161

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 5 Unrelated Failures

As of commit 5e35908 with merge base bde6b11 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2025
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Oct 17, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 317071315
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Oct 17, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 317106395
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Oct 20, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 317368561
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Oct 21, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 317645474
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Oct 21, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 317683544
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
…eduction"

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Nov 4, 2025
Pull Request resolved: #15161

Title says it all!

This diff also adds support for argmin and argmax, but only for per-row reduction.
ghstack-source-id: 320871909
@exported-using-ghexport

Differential Revision: [D84716454](https://our.internmc.facebook.com/intern/diff/D84716454/)
@meta-codesync meta-codesync bot merged commit b35cb7c into gh/SS-JIA/344/base Nov 5, 2025
200 of 208 checks passed
@meta-codesync meta-codesync bot deleted the gh/SS-JIA/344/head branch November 5, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants