Skip to content

Conversation

@haowhsu-quic
Copy link
Collaborator

@haowhsu-quic haowhsu-quic commented Oct 15, 2025

Summary

  • fix annotation logic for non arithmetic op
  • partition out unsupported embedding_bag op
  • use calibration input in suite test when verifying quantized op

Test plan

e.g. pytest --disable-warnings -c /dev/nul backends/test/suite/ -k test_split_size_dimensions[qnn_16a16w]

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15162

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 05f1e41 with merge base f81d768 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2025
@haowhsu-quic
Copy link
Collaborator Author

Hi @cccclai, if the framework change makes sense to you. I still need some time to test all the decoder models thoroughly since the annotation change of concat will somewhat impact the accuracy of kv_cache. Will ping you again once all of them are well tested.

- fix annotation logic for non arithmetic op
- partition out unsupported embedding_bag op
- use calibration input in suite test when verifying quantized op
@haowhsu-quic haowhsu-quic marked this pull request as ready for review October 21, 2025 17:19
@haowhsu-quic haowhsu-quic requested a review from cccclai as a code owner October 21, 2025 17:19
@cccclai
Copy link
Contributor

cccclai commented Oct 22, 2025

It seems like some tests are failing..

@haowhsu-quic haowhsu-quic marked this pull request as draft October 22, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants