Skip to content

Conversation

@sxu
Copy link
Contributor

@sxu sxu commented Oct 16, 2025

Summary:
Sometimes the ModelArgs object is not available. This diff provides an alternative way to initialize the IO manager from any module that contains StaticAttention. The assumption is that the RoPE setting of those attentions modules are all the same.

Differential Revision: D84854882

…aticAttention inside

Summary:
Sometimes the `ModelArgs` object is not available, for example:
https://www.internalfb.com/code/fbsource/[3243b3d06108fff9ab5a9062905844454e600e1d]/fbcode/assistant/multimodal/llm_mm_aligner/lib/models/minymal/model_export/export_vlm.py?lines=161-164

This diff provides an alternative way to initialize the IO manager from any module that contains `StaticAttention`. The assumption is that the RoPE setting of those attentions modules are all the same.

Differential Revision: D84854882
@sxu sxu requested review from jackzhxng and lucylq as code owners October 16, 2025 20:56
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15206

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 6 Cancelled Jobs, 1 Unrelated Failure

As of commit 36d4b58 with merge base 651b357 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 16, 2025

@sxu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84854882.

@sxu sxu requested review from YIWENX14 and billmguo October 16, 2025 20:57
@sxu sxu added the release notes: none Do not include this in the release notes label Oct 16, 2025
@meta-codesync meta-codesync bot merged commit 9acd52b into pytorch:main Oct 17, 2025
141 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants