Skip to content

Conversation

@michaelmaitland
Copy link
Contributor

Summary:
Fixed two bugs in fbcode/executorch/backends/cadence/aot/functions_hifi.yaml:

  1. cadence::quantize_per_tensor_asym16u was incorrectly mapped to impl::HiFi::quantize_per_tensor_asym16s_out instead of asym16u_out
  2. cadence::dequantize_per_tensor_asym32s was incorrectly mapped to impl::HiFi::dequantize_per_tensor_asym16s_out instead of asym32s_out

The second bug caused runtime failures when dequantizing 32-bit signed integer tensors, as the wrong function expecting 16-bit integers was called, resulting in "Unhandled input dtype" assertion failures.

Differential Revision: D84865463

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15216

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 3 Cancelled Jobs, 3 Unrelated Failures

As of commit be6e26c with merge base 98baab7 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link

meta-codesync bot commented Oct 17, 2025

@michaelmaitland has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84865463.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@michaelmaitland michaelmaitland added the release notes: cadence Changes to the Cadence backend delegate label Oct 17, 2025
michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request Oct 17, 2025
…#15216)

Summary:

Fixed two bugs in fbcode/executorch/backends/cadence/aot/functions_hifi.yaml:
  1. cadence::quantize_per_tensor_asym16u was incorrectly mapped to impl::HiFi::quantize_per_tensor_asym16s_out instead of asym16u_out
  2. cadence::dequantize_per_tensor_asym32s was incorrectly mapped to impl::HiFi::dequantize_per_tensor_asym16s_out instead of asym32s_out

The second bug caused runtime failures when dequantizing 32-bit signed integer tensors, as the wrong function expecting 16-bit integers was called, resulting in "Unhandled input dtype" assertion failures.

Differential Revision: D84865463
michaelmaitland pushed a commit to michaelmaitland/executorch that referenced this pull request Oct 17, 2025
…#15216)

Summary:

Fixed two bugs in fbcode/executorch/backends/cadence/aot/functions_hifi.yaml:
  1. cadence::quantize_per_tensor_asym16u was incorrectly mapped to impl::HiFi::quantize_per_tensor_asym16s_out instead of asym16u_out
  2. cadence::dequantize_per_tensor_asym32s was incorrectly mapped to impl::HiFi::dequantize_per_tensor_asym16s_out instead of asym32s_out

The second bug caused runtime failures when dequantizing 32-bit signed integer tensors, as the wrong function expecting 16-bit integers was called, resulting in "Unhandled input dtype" assertion failures.

Differential Revision: D84865463
…#15216)

Summary:

Fixed two bugs in fbcode/executorch/backends/cadence/aot/functions_hifi.yaml:
  1. cadence::quantize_per_tensor_asym16u was incorrectly mapped to impl::HiFi::quantize_per_tensor_asym16s_out instead of asym16u_out
  2. cadence::dequantize_per_tensor_asym32s was incorrectly mapped to impl::HiFi::dequantize_per_tensor_asym16s_out instead of asym32s_out

Differential Revision: D84865463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: cadence Changes to the Cadence backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant