Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Oct 17, 2025

Adds a pass which checks if a node has multiple users performing equivalent operations its output. If that is the case, it fuses these ops into one.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

GEN AI USED - BLACKDUCK APPROVED

Adds a pass which checks if a node has multiple users
performing equivalent operations its output. If that is the case,
it fuses these ops into one.

Change-Id: I10f698429af8e2e7f1130c391d7e9e94616fa5e4
Signed-off-by: Adrian Lundell <[email protected]>
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 17, 2025
@AdrianLundell AdrianLundell added ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15218

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 11d76ab with merge base 94ce147 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

I'll rebase to get the test-mcu-model error out of the way

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

Failed with
FAILED backends/arm/test/ops/test_tanh.py::test_tanh_16a8w_tosa_INT[rand] - AssertionError: Output 0 does not match reference output.
Given atol: 0.0010152587890625, rtol: 0.001.
Output tensor shape: torch.Size([10, 10]), dtype: torch.float32
Difference: max: 1.52587890625e-05, abs: 0.00152587890625, mean abs error: 2.6092529296875e-05.
-- Model vs. Reference --
Numel: 100, 100
Median: -0.0678253173828125, -0.0678253173828125
Mean: -0.0142254638671875, -0.014200897216796874
Max: 0.4605865478515625, 0.4621124267578125
Min: -0.4584808349609375, -0.4584808349609375
= 1 failed, 3050 passed, 2534 skipped, 2239 xfailed, 115 xpassed, 982 warnings in 2753.46s (0:45:53) =

This is probably just a flakey test Retrigger

@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

Added files in _passes is part of a buck2 *.py rule so this should work in buck2
Fails are unrelated

@zingo zingo merged commit 7bd34b8 into pytorch:main Oct 30, 2025
381 of 386 checks passed
@AdrianLundell AdrianLundell deleted the change-1125706 branch November 7, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants