Skip to content

Conversation

robert-kalmar
Copy link
Collaborator

Updating per template in #14873

Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15219

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 02374b7 with merge base 53c1a77 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@robert-kalmar robert-kalmar requested review from digantdesai and removed request for mergennachin October 17, 2025 11:03
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@robert-kalmar robert-kalmar force-pushed the update-nxp-doc-new-template branch 2 times, most recently from 92eb4cb to fb21899 Compare October 17, 2025 12:50
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just backend with capital B and I see no further issues.

@@ -1,79 +0,0 @@
# NXP eIQ Neutron Backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the XNNPACK files I see both, there is capital Backend in "XNNPACK Backend" at least in headings. What I meant is to unify it, as we have strings "NXP Backend" as well as "NXP backend". That is just a cosmetic issue. As it is a backend name, I think both words should be capitalized as it is a general rule in English. XNNPACK docs can also have mistakes.

EDIT: I have looked on other backends and they are mostly inconsistent too. It should be one or the other, but always capitalized in headings.

@robert-kalmar robert-kalmar force-pushed the update-nxp-doc-new-template branch from 50e151c to 02374b7 Compare October 17, 2025 15:36
@robert-kalmar
Copy link
Collaborator Author

In the XNNPACK files I see both, there is capital Backend in "XNNPACK Backend" at least in headings. What I meant is to unify it, as we have strings "NXP Backend" as well as "NXP backend". That is just a cosmetic issue. As it is a backend name, I think both words should be capitalized as it is a general rule in English. XNNPACK docs can also have mistakes.

EDIT: I have looked on other backends and they are mostly inconsistent too. It should be one or the other, but always capitalized in headings.

You are right, with the consistency. Went through it and unified it to use lower case everywhere. So Neutron backend, Neutron partitioner, Neutron quantizer....
In headings using capitals for all major words, i.e. using the "Title case" (https://en.wikipedia.org/wiki/Title_case) style headings.


## Step 1: Environment Setup

This tutorial is intended to be run from a Linux and uses Conda or Virtual Env for Python environment management. For full setup details and system requirements, see [Getting Started with ExecuTorch](/getting-started).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link gives 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants