-
Notifications
You must be signed in to change notification settings - Fork 688
NXP Backend: Update documentation to the new scheme #15219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP Backend: Update documentation to the new scheme #15219
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15219
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 02374b7 with merge base 53c1a77 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
92eb4cb
to
fb21899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just backend with capital B and I see no further issues.
@@ -1,79 +0,0 @@ | |||
# NXP eIQ Neutron Backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's another reference of this https://github.com/pytorch/executorch/blob/53c1a77166c6478ad30b0e1c0e2c4f5247693e6a/docs/source/embedded-nxp.md?plain=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
fb21899
to
50e151c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the XNNPACK files I see both, there is capital Backend in "XNNPACK Backend" at least in headings. What I meant is to unify it, as we have strings "NXP Backend" as well as "NXP backend". That is just a cosmetic issue. As it is a backend name, I think both words should be capitalized as it is a general rule in English. XNNPACK docs can also have mistakes.
EDIT: I have looked on other backends and they are mostly inconsistent too. It should be one or the other, but always capitalized in headings.
50e151c
to
02374b7
Compare
You are right, with the consistency. Went through it and unified it to use lower case everywhere. So Neutron backend, Neutron partitioner, Neutron quantizer.... |
|
||
## Step 1: Environment Setup | ||
|
||
This tutorial is intended to be run from a Linux and uses Conda or Virtual Env for Python environment management. For full setup details and system requirements, see [Getting Started with ExecuTorch](/getting-started). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link gives 404.
Updating per template in #14873