Skip to content

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Oct 17, 2025

backends/vulkan/runtime/utils/StorageUtils.h was referring to definitions like uint8_t without including the header cstdint. This resulted in a risk of facing compilation errors on some systems. Fix this problem by including the header.

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

backends/vulkan/runtime/utils/StorageUtils.h was referring to
definitions like `uint8_t` without including the header cstdint. This
resulted in a risk of facing compilation errors on some systems. Fix
this problem by including the header.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: I32ec2d3c9bc7e65c3baf1c2a100a5f95f180691d
@martinlsm martinlsm requested a review from SS-JIA as a code owner October 17, 2025 13:11
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Oct 17, 2025
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15220

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 935a0a6 with merge base 7215b88 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@martinlsm
Copy link
Collaborator Author

martinlsm commented Oct 21, 2025

This problem is causing issues in our CI-tests so it would be great if we could merge this patch ASAP

@SS-JIA SS-JIA merged commit 2b80602 into pytorch:main Oct 22, 2025
137 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants