-
Notifications
You must be signed in to change notification settings - Fork 691
Vulkan backend: Add missing include of cstdint #15220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
backends/vulkan/runtime/utils/StorageUtils.h was referring to definitions like `uint8_t` without including the header cstdint. This resulted in a risk of facing compilation errors on some systems. Fix this problem by including the header. Signed-off-by: Martin Lindström <[email protected]> Change-Id: I32ec2d3c9bc7e65c3baf1c2a100a5f95f180691d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15220
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 2 Unrelated FailuresAs of commit 935a0a6 with merge base 7215b88 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This problem is causing issues in our CI-tests so it would be great if we could merge this patch ASAP |
backends/vulkan/runtime/utils/StorageUtils.h was referring to definitions like
uint8_t
without including the header cstdint. This resulted in a risk of facing compilation errors on some systems. Fix this problem by including the header.cc @SS-JIA @manuelcandales @digantdesai @cbilgin