Msvc ops changes

[JacobSzwejbka]

Summary

MSVC really doesn't like the constexpr variables that I've removed in this PR. It was complaining about them not actually being static at compile time. Searching around suggests that its the act of putting them in a variable that breaks it and if I just place the value directly in all the used locations it should be fine. I tried that and it works.

The other changes are fixing up some compiler flags, adding a missing include, fixing an interaction between lambdas the ternary operator and auto, and removing unneeded statement expressions

Test plan

current ci to verify no regression on linux/mac. Manual testing of msvc will add ci soon

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15226

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• AWS was down, GHA infrastructure effected / recovering

❌ 5 New Failures, 1 Cancelled Job

As of commit 904b2b4 with merge base 173b046 ():

NEW FAILURES - The following jobs have failed:

• Build Presets / apple (llm) / build (gh)
  The process '/opt/homebrew/bin/git' failed with exit code 128
• Build Windows Wheels / pytorch/executorch / build-wheel-py3_10-cpu (gh)
• Build Windows Wheels / pytorch/executorch / upload / upload-wheel-py3_10-cpu (gh)
  Unable to download artifact(s): Artifact not found for name: pytorch_executorch__3.10_cpu_x64
• Test CUDA Builds / export-voxtral-cuda-quantized-int4-tile-packed / linux-job (gh)
  RuntimeError: Command docker exec -t 1eb231b2631cf3d6750d7efcb3f7afa90aff80546a53a71a4dc0caab4ec0e495 /exec failed with exit code 2
• Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

CANCELLED JOB - The following job was cancelled. Please retry:

• periodic / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[swolchok]

if this requires more than 1-2 more review rounds, you might be able to move faster by splitting out the uncontroversial strings changes; I could approve those right away.

[JacobSzwejbka]

oh missed one.

[swolchok]

looks good, just a couple minor comments