Skip to content

Conversation

3l1
Copy link
Contributor

@3l1 3l1 commented Oct 19, 2025

Summary: Enable int16 for op permute

Reviewed By: Ninja91

Differential Revision: D84948536

@3l1 3l1 requested a review from digantdesai as a code owner October 19, 2025 02:12
Copy link

pytorch-bot bot commented Oct 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15256

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit f4ff144 with merge base b495fa3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-codesync bot commented Oct 19, 2025

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84948536.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2025
@3l1
Copy link
Contributor Author

3l1 commented Oct 19, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Oct 19, 2025
@3l1 3l1 requested a review from Ninja91 October 19, 2025 02:13
facebook-github-bot pushed a commit that referenced this pull request Oct 19, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 19, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91

Differential Revision: D84948536

def forward(self, x):
return self.permute(x)
return torch.permute(x, self.dims)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a cleanup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is to avoid importing torchvision


def forward(self, x):
return self.permute(x)
return torch.permute(x, self.dims)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add int16 test?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

3l1 added a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from feb0383 to a4502d1 Compare October 21, 2025 15:11
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
3l1 added a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from e328a4d to e9030db Compare October 21, 2025 15:48
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
3l1 added a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from e9030db to 7ec2317 Compare October 21, 2025 15:53
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
3l1 added a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from b667fc0 to f1074ba Compare October 21, 2025 18:08
3l1 added a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from f1074ba to 35a3ddc Compare October 21, 2025 19:59
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 21, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
3l1 added a commit that referenced this pull request Oct 22, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@3l1 3l1 force-pushed the export-D84948536 branch from 5345627 to 70e9586 Compare October 22, 2025 00:06
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
3l1 added a commit that referenced this pull request Oct 22, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 22, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
facebook-github-bot pushed a commit that referenced this pull request Oct 22, 2025
Summary:

Enable int16 for op permute

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: Ninja91, digantdesai

Differential Revision: D84948536
@meta-codesync meta-codesync bot merged commit 6307924 into main Oct 22, 2025
146 of 151 checks passed
@meta-codesync meta-codesync bot deleted the export-D84948536 branch October 22, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants