-
Notifications
You must be signed in to change notification settings - Fork 691
Enable int16 for op permute #15256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable int16 for op permute #15256
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15256
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit f4ff144 with merge base b495fa3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: none" |
Summary: Enable int16 for op permute Reviewed By: Ninja91 Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91 Differential Revision: D84948536
|
||
def forward(self, x): | ||
return self.permute(x) | ||
return torch.permute(x, self.dims) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just a cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is to avoid importing torchvision
|
||
def forward(self, x): | ||
return self.permute(x) | ||
return torch.permute(x, self.dims) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add int16 test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
a4502d1
to
a7695f3
Compare
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
a7695f3
to
e328a4d
Compare
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
7ec2317
to
ba878c1
Compare
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
ba878c1
to
b667fc0
Compare
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
35a3ddc
to
2beefcf
Compare
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
2beefcf
to
0a66af3
Compare
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
0a66af3
to
41e563e
Compare
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
41e563e
to
5345627
Compare
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
70e9586
to
f4ff144
Compare
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Reviewed By: Ninja91, digantdesai Differential Revision: D84948536
Summary: Enable int16 for op permute
Reviewed By: Ninja91
Differential Revision: D84948536