Skip to content

Conversation

swolchok
Copy link
Contributor

I previously added runtime::FunctionRef and used it in parallel_for to save code size, but didn't carry that through to the Threadpool wrapper. Profiling showed that we were doing heap allocations on each parallel_for invocation, so let's fix that.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Oct 20, 2025

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from kimishpatel as a code owner October 20, 2025 00:38
Copy link

pytorch-bot bot commented Oct 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15265

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 4 Unrelated Failures

As of commit c40189a with merge base 2e8e579 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Oct 20, 2025
I previously added runtime::FunctionRef and used it in parallel_for to save code size, but didn't carry that through to the Threadpool wrapper. Profiling showed that we were doing heap allocations on each parallel_for invocation, so let's fix that.


ghstack-source-id: 70b4daa
ghstack-comment-id: 3420130780
Pull-Request: #15265
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2025
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Oct 20, 2025
@swolchok swolchok requested a review from mergennachin October 20, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant