Skip to content

Conversation

phaiting
Copy link
Contributor

The generate API for llm has two issues.

  • The input image could be null, but prefillImages assume non-null, this cause prefillImages return Error::EndOfMethod, this can be fixed by adding a null check on the java layer
  • The generate didn't pass prompt which caused stack overflow

Test plan
Run all e2e test on the local emulator and run via CI

The generate API for llm has two issues.
- The input image could be null, but prefillImages assume non-null, this cause prefillImages return Error::EndOfMethod, this can be fixed by adding a null check on the java layer
- The generate didn't pass prompt which caused stack overflow
Copy link

pytorch-bot bot commented Oct 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15275

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 3 Unrelated Failures

As of commit 4638277 with merge base 73f7286 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2025
@phaiting
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Oct 20, 2025
@phaiting phaiting merged commit fe3c1dc into main Oct 20, 2025
143 of 156 checks passed
@phaiting phaiting deleted the e2e-llm branch October 20, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants