Fix text_llm_runner kv cache pos count and use it for generate() #15286
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15286
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 12545a3 with merge base 58bd91c ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kirklandsign
requested review from
jackzhxng,
larryliu0820,
mergennachin and
swolchok
as code owners
meta-cla
bot
added
the
CLA Signed
larryliu0820
approved these changes
Oct 20, 2025
kirklandsign
changed the title
| } | ||
| int64_t num_generated_tokens = generate_result.get(); | ||
|
|
||
| pos_ += num_generated_tokens; |
There was a problem hiding this comment.
you don't need this anymore right? pos_ is being updated.
kirklandsign
added
module: llm
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 21, 2025
) pos_ should advance by prefill and generated prompt size. (cherry picked from commit 8946d80)
Cherry picking #15286The cherry pick PR is at #15295 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pos_ should advance by prefill and generated prompt size.
Test plan
CI
cc @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng