-
Notifications
You must be signed in to change notification settings - Fork 691
Arm backend: Merge passes that replace scalars #15298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Besides having obsolete names, ReplaceScalarWithTensorPassTOSAMI and ReplaceScalarWithTensorPassTOSABI was causing difficulties for defining chronological pass dependencies with the `_passes_required_after` attribute. This is because, with the current design, there is no way to distinguish which profile is referred to when defining `_passes_required_after`; a pass simply declares its chronological dependencies globally. Solve this by merging the two pass classes together into one called `ReplaceScalarWithTensorByProfilePass`. This means that a pass should include this new pass in `_passes_required_after` no matter which TOSA profile its working towards. Signed-off-by: Martin Lindström <[email protected]> Change-Id: I00c0e3658426fb5c1da996eeee89093a395630db
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15298
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Cancelled Job, 4 Unrelated FailuresAs of commit b040270 with merge base 7215b88 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label ciflow/trunk |
@pytorchbot label "partner: arm" |
This PR needs a
|
Besides having obsolete names, ReplaceScalarWithTensorPassTOSAMI and ReplaceScalarWithTensorPassTOSABI was causing difficulties for defining chronological pass dependencies with the
_passes_required_after
attribute. This is because, with the current design, there is no way to distinguish which profile is referred to when defining_passes_required_after
; a pass simply declares its chronological dependencies globally.Solve this by merging the two pass classes together into one called
ReplaceScalarWithTensorByProfilePass
. This means that a pass should include this new pass in_passes_required_after
no matter which TOSA profile its working towards.Test plan
This is a refactoring patch. No behavior is modified. Thus the tests already in place are enough to test this change.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai