-
Notifications
You must be signed in to change notification settings - Fork 691
Fixing issues with using buffers for quantized linear weights. #15306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trivedivivek
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
trivedivivek:export-D84870681
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15306
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 1 Pending, 2 Unrelated FailuresAs of commit ca24759 with merge base 6e08aef ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84870681. |
SS-JIA
approved these changes
Oct 21, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 21, 2025
…ch#15306) Summary: This diff issues related to using buffers for quantized linear weights in the Executorch Vulkan backend. The changes include: * Using uint for buffer weight storage instead of uint8 and packing / unpacking integer values accordingly. * Updating the shader parameters in `QuantizedLinearQCSNW.cpp` to include the correct sizes for the packed weights. Reviewed By: SS-JIA Differential Revision: D84870681
97b3431
to
e95afff
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 21, 2025
…ch#15306) Summary: This diff issues related to using buffers for quantized linear weights in the Executorch Vulkan backend. The changes include: * Using uint for buffer weight storage instead of uint8 and packing / unpacking integer values accordingly. * Updating the shader parameters in `QuantizedLinearQCSNW.cpp` to include the correct sizes for the packed weights. Reviewed By: SS-JIA Differential Revision: D84870681
86e5fbb
to
8b259c6
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 22, 2025
…ch#15306) Summary: This diff issues related to using buffers for quantized linear weights in the Executorch Vulkan backend. The changes include: * Using uint for buffer weight storage instead of uint8 and packing / unpacking integer values accordingly. * Updating the shader parameters in `QuantizedLinearQCSNW.cpp` to include the correct sizes for the packed weights. Reviewed By: SS-JIA Differential Revision: D84870681
…ch#15306) Summary: This diff issues related to using buffers for quantized linear weights in the Executorch Vulkan backend. The changes include: * Using uint for buffer weight storage instead of uint8 and packing / unpacking integer values accordingly. * Updating the shader parameters in `QuantizedLinearQCSNW.cpp` to include the correct sizes for the packed weights. Reviewed By: SS-JIA Differential Revision: D84870681
8b259c6
to
ca24759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
release notes: vulkan
Changes to the Vulkan backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff issues related to using buffers for quantized linear weights in the Executorch Vulkan backend.
The changes include:
QuantizedLinearQCSNW.cpp
to include the correct sizes for the packed weights.Differential Revision: D84870681