Skip to content

Conversation

@eigen-k
Copy link
Contributor

@eigen-k eigen-k commented Oct 21, 2025

Summary:
This diff moves RemoveCatFromSliceCopyPass after MovePermuteAfterConcat because the latter pass may introduce the new cat-slice pairs.

With this diff in, the unwanted cat ops described in task, get optimized:
{F1982857385}

Reviewed By: hsharma35

Differential Revision: D85087930

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15312

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 2627a62 with merge base 7f68c4f (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 21, 2025

@eigen-k has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85087930.

@eigen-k eigen-k added the release notes: none Do not include this in the release notes label Oct 21, 2025
Summary:

This diff moves RemoveCatFromSliceCopyPass after MovePermuteAfterConcat because the latter pass may introduce the new cat-slice pairs.

With this diff in, the unwanted cat ops described in task, get optimized:
 {F1982857385}

Reviewed By: hsharma35, DrJessop

Differential Revision: D85087930
@meta-codesync meta-codesync bot merged commit 331d771 into pytorch:main Oct 22, 2025
137 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants