Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #15313 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/121/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/121/orig
Differential Revision: D85169688
@diff-train-skip-merge

Enforce that the data loader size must be at least as large as the header size, not exactly.

We are introducing a dual address data loader, which takes in two loaders, one for flatbuffer-only, and one for the full PTD file. The DualAddressDataLoader returns size as the combined size of both loaders. This will end up being larger than the PTD file size in the header.

The new data loader allows users to address int64 and int32 at the same time.

Differential Revision: [D85169688](https://our.internmc.facebook.com/intern/diff/D85169688/)

ghstack-source-id: 317712776
Pull Request resolved: #15313
@pytorchbot pytorchbot requested a review from lucylq as a code owner October 21, 2025 23:02
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15334

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 44 Pending

As of commit 0c5cf9d with merge base 7349bb5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq merged commit b495fa3 into main Oct 21, 2025
137 of 144 checks passed
@lucylq lucylq deleted the gh/lucylq/121/orig branch October 21, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants