Skip to content

Minor doc fixes #15336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Minor doc fixes #15336

merged 1 commit into from
Oct 22, 2025

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Oct 21, 2025 •
edited
Loading

Summary

Fix heading level for build verification, cleanup wording on Windows reqs, update android presets since they were split by arch.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15336

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 16 Pending

As of commit 24e8a40 with merge base b495fa3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@GregoryComer GregoryComer requested a review from psiddh October 21, 2025 23:52
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

GregoryComer
GregoryComer commented Oct 21, 2025
View reviewed changes
docs/source/getting-started.md
- Linux (x86_64 or ARM64), macOS (ARM64), or Windows (x86_64).
- Intel-based macOS systems require building PyTorch from source (see [Building From Source](using-executorch-building-from-source.md) for instructions).
- On Windows, Visual Studio 2022 or later. Clang build tools are needed to build from source.
- On Windows, Visual Studio 2022 or later.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the build from source callout as it's covered in the building from source section. We do still need VS 2022 because torch.export does C++ compilation (via MSVC) in strict mode.

@GregoryComer GregoryComer merged commit d4e22c1 into pytorch:main Oct 22, 2025
122 of 127 checks passed
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Oct 22, 2025
@GregoryComer
Minor doc fixes (pytorch#15336)
89b5071 
### Summary
Fix heading level for build verification, cleanup wording on Windows
reqs, update android presets since they were split by arch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh psiddh approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer @psiddh @kirklandsign