Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 23, 2025

Control flow operators are implemented with get_attr/ placeholders nodes pointing to submodules in the graph_module. To know if we can handle such an operators, we need to figure out whether we can partition all of the submodule the operator points to. We can do this simply by applying the partition logic we already have to submodules. This has the added benefit that we will partition parts of submodules into normal partitions, even if we can't partition the full submodule.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

This prepares the partitioner for partitioning submodules.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ie3123c672ad4df93b8a9f835c3908d58668e27d2
Recursively search for control_flow_modules and tag them
in _tag_module function in partitioner.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Idb41e7f808013936dae8ca6909a69d053e834ca9
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15364

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 3 Unrelated Failures

As of commit c67e327 with merge base f7ca57e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 23, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CI failures

@Sebastian-Larsson Sebastian-Larsson merged commit b24c39a into pytorch:main Oct 23, 2025
289 of 300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants