-
Notifications
You must be signed in to change notification settings - Fork 696
Arm backend: Tag control flow submodules in partitioner #15364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This prepares the partitioner for partitioning submodules. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ie3123c672ad4df93b8a9f835c3908d58668e27d2
Recursively search for control_flow_modules and tag them in _tag_module function in partitioner. Signed-off-by: Erik Lundell <[email protected]> Change-Id: Idb41e7f808013936dae8ca6909a69d053e834ca9
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15364
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 3 Unrelated FailuresAs of commit c67e327 with merge base f7ca57e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated CI failures
Control flow operators are implemented with get_attr/ placeholders nodes pointing to submodules in the graph_module. To know if we can handle such an operators, we need to figure out whether we can partition all of the submodule the operator points to. We can do this simply by applying the partition logic we already have to submodules. This has the added benefit that we will partition parts of submodules into normal partitions, even if we can't partition the full submodule.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai