Add check for negative index in cpu kernel op_index #15366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Larsson
requested review from
manuelcandales and
swolchok
as code owners
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15366
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 2 Pending, 4 Unrelated FailuresAs of commit b2d4503 with merge base de56c81 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Sebastian-Larsson
added
release notes: ops & kernels
swolchok
suggested changes
Oct 23, 2025
Contributor
swolchok
left a comment
swolchok
left a comment
There was a problem hiding this comment.
looks fine; inline comments are for your consideration and not blocking. However, please also add a test for this behavior (and feel free to @ me for re-review to avoid extra delay).
Fast path cannot be taken when the index is negative in op_index. It results in a failure in `check_fast_path_args`. Add a check to `check_fast_path_conditions` for negative index and return `false` if one is encountered. Change-Id: I6c3fb1793da9a0831ef41a47dc2ab4423aa38be3 Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
force-pushed
the
negative_index_fix
branch
from
0315d9b to
b2d4503
Compare
Collaborator
Author
|
Changed to your suggestions and added tests @swolchok |
swolchok
approved these changes
Oct 24, 2025
| EXPECT_TENSOR_EQ(ret, expected); | ||
| } | ||
|
|
||
| TEST_F(OpIndexTensorOutTest, NegativeIndexSupportedForInt) { |
Contributor
There was a problem hiding this comment.
I would prefer to see a templated test, but it's probably not worth blocking on
Contributor
|
looks like we have a bunch of infra failures and known flakes in CI. merging. |
lucylq
pushed a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 6, 2025
Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194
Contributor
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Fast path cannot be taken when the index is negative in op_index. It results in a failure in `check_fast_path_args`. Add a check to `check_fast_path_conditions` for negative index and return `false` if one is encountered. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Sebastian Larsson <[email protected]> (cherry picked from commit d6de876)
Collaborator
Cherry picking #15366The cherry pick PR is at #15646 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
pytorchbot
pushed a commit
that referenced
this pull request
Nov 6, 2025
Fast path was broken for negative indices (see #15285) Because of this, #15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes #15285 Differential Revision: D86351194 (cherry picked from commit 2fa44ea)
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194
GregoryComer
pushed a commit
that referenced
this pull request
Nov 6, 2025
Fast path was broken for negative indices (see #15285) Because of this, #15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes #15285 Differential Revision: D86351194 Co-authored-by: Manuel Candales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast path cannot be taken when the index is negative in op_index. It results in a failure in
check_fast_path_args. Add a check tocheck_fast_path_conditionsfor negative index and returnfalseif one is encountered.cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai