-
Notifications
You must be signed in to change notification settings - Fork 751
Arm backend: Fix arg-type MyPy errors #15367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce function `ensure_type()` which throws an exception if the expected dtype is incorrect. This solves a number of mypy errors spread around the codebase. Additionally, fix arg-type mypy errors. Change-Id: I2677944ac70b44b913d1817c4225707b2bc39e14 Signed-off-by: Sebastian Larsson <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15367
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 3 Unrelated FailuresAs of commit f88d250 with merge base fdfeaa4 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mansnils
approved these changes
Oct 23, 2025
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Oct 27, 2025
This reverts commit c66078c.
meta-codesync bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
Differential Revision: D85886023 Pull Request resolved: #15478
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
…5367) Differential Revision: D85886023 Pull Request resolved: pytorch#15478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
partner: arm
For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
release notes: arm
Changes to the ARM backend delegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce function
ensure_type()which throws an exception if the expected dtype is incorrect. This solves a number of mypy errors spread around the codebase.Additionally, fix arg-type mypy errors.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai