Skip to content

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented Oct 23, 2025

Executor runner supports both models with/wo bundled io in same path.
To enable bundled IO EXECUTORCH_BUILD_DEVTOOLS and
EXECUTORCH_ENABLE_BUNDLE_IO are required.

Adds tests in Arm backend for testing this/depending on this.
Except for enabling bundle-io for VGF backend where applicable,
some additional resnets model tests are enabled as well.

Avoids narrowing conversion errors in pte_to_header script by switching
char to unsigned char.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 23, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 3 Unrelated Failures

As of commit b024c7c with merge base de56c81 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025
@mansnils
Copy link
Collaborator Author

Need to either add DEVTOOLS=ON to all cmake recipes that builds the executor runner or use an optional build flag.

}

if (bundle_io) {
// With bundled io we can check the result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file gets copy pasted a ton as a basic example of a runner. Im pretty resistant to something like this which will tempt people to use it it as a tester. Im already not a huge fan of having the benchmarking stuff in here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now an optional build flag.

using executorch::runtime::Tag;
using executorch::runtime::TensorInfo;

#if defined(ET_BUNDLE_IO_ATOL)
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use gflags to pass these as an arg

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do


std::stringstream list_of_input_files(FLAGS_inputs);
std::string path;
if (!bundle_io) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are .ptd and bundledProgram mutually exclusive? @lucylq @Gasoonjia.

ptd is only used to pass weights along its not another way to pass inputs to this file afaik

Executor runner supports both models with/wo bundled io in same path.
To enable bundled IO EXECUTORCH_BUILD_DEVTOOLS and
EXECUTORCH_ENABLE_BUNDLE_IO are required.

Adds tests in Arm backend for testing this/depending on this.
Except for enabling bundle-io for VGF backend where applicable,
some additional resnets model tests are enabled as well.

Avoids narrowing conversion errors in pte_to_header script by switching
char to unsigned char.

Signed-off-by: Måns Nilsson <[email protected]>
Change-Id: Iffdf6c253a57b01abb02758b6ba2d1e3de25e3d8
@mansnils
Copy link
Collaborator Author

Need to either add DEVTOOLS=ON to all cmake recipes that builds the executor runner or use an optional build flag.

This comment should be resolved now.
Apologies for force push after your comments @JacobSzwejbka

Change-Id: I91ca1425bc023a37656704b3bae82da26cbd58e4
Also slightly change condition in order to avoid confusing print,
'Loading inputs from input file(s)' when no files where provided.

Change-Id: Icc9c1faa50a1c00e0a6ccf12c85b687af736f6b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants