- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
Arm backend: Fix U55 int16 table generation #15390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15390
 Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: 
 ❌ 17 New Failures, 1 Cancelled Job, 11 Unrelated FailuresAs of commit ae665fa with merge base 4c58010 ( NEW FAILURES - The following jobs have failed:
 
 CANCELLED JOB - The following job was cancelled. Please retry:
 
 FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
 
 BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures 
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
| @pytorchbot label "release notes: none" | 
Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
2818744    to
    5f1b2f2      
    Compare
  
    Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
69d9e88    to
    b8c0a00      
    Compare
  
    Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
b8c0a00    to
    c7e7b03      
    Compare
  
    Summary: This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh) **WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)** bypass-github-export-checks bypass-github-pytorch-ci-checks bypass-github-executorch-ci-checks Differential Revision: D85312140
| @common.parametrize("test_data", test_data_suite) | ||
| @common.parametrize("test_data", test_data_suite_no_rand_4d) | ||
| @common.XfailIfNoCorstone300 | ||
| @pytest.mark.xfail( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: restore xfails unti regor oss is in sync
| I am told by Arm that they have an alternate, TOSA compliant, solution in Regor https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-vela/-/commit/5e8dd39861595e62287340802ab37812bda3d369 & https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-vela/-/commit/90e7cff2426c36876a2d2115b84844ecb39040ef let's wait until this makes it to the Executorch repo before deciding to land this PR or not | 
| Move this to "draft" while waiting on Vela, just did it for slightly easier overview on GitHub, feel free to disagree and put it back of you want it as non draft if work both ways for me :) . | 
Summary:
This diff fixes critical runtime bugs in U55 INT16 table operations (rsqrt, sigmoid, tanh)
WARNING: This diff goes with the Regor diff D85535937 and is only split because it maps to a separate OSS github repo (the Arm Regor git repo)
bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks
Differential Revision: D85312140
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai