Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 28, 2025

If a linear is not quantized properly, we will reject it when partitioning. However, if we tell Executorch to not not decompose an op, we are required to partition it. We thus need to figure out if we will partition the linear or not in the ops_not_to_decompose filter function.

Also turn off grad in the arm tester to solve an error that popped up in the GRU model. Since we only do inference, grad is never relevant.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Oct 28, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15406

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 4ad83fa with merge base c1c5a71 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
If a linear is not quantized properly, we will reject it
when partitioning. However, if we tell Executorch to _not_
not decompose an op, we are required to partition it.
We thus need to figure out if we will partition the linear
or not in the ops_not_to_decompose filter function.

Also turn off grad in the arm tester to solve an error that popped
up in the GRU model. Since we only do inference, grad is
never relevant.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Iaef8671cc89b290ec539ad236fb3450a3dde7c73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant