Skip to content

[aoti-et] Add dtype bool support #15434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

[aoti-et] Add dtype bool support #15434

merged 1 commit into from
Oct 29, 2025
+22 −1

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Oct 28, 2025 •
edited
Loading

As titled.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15434

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 08adaf3 with merge base 30d7cae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Gasoonjia
Gasoonjia approved these changes Oct 28, 2025
View reviewed changes
backends/cuda/runtime/utils.h
is_dtype_supported_in_et_cuda(dtype),
InvalidArgument,
"Unsupported dtype: %d. Supported dtypes: %d (int8), %d (int16), %d (int32), %d (int64), %d (float32), %d (bfloat16)",
"Unsupported dtype: %d. Supported dtypes: %d (int8), %d (int16), %d (int32), %d (int64), %d (float32), %d (bool), %d (bfloat16)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any macro we can use here? seems it is getting longer and longer loll

@larryliu0820 larryliu0820 merged commit 33bcde1 into main Oct 29, 2025
152 of 154 checks passed
@larryliu0820 larryliu0820 deleted the cuda_bool branch October 29, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gasoonjia Gasoonjia Gasoonjia approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larryliu0820 @Gasoonjia