Skip to content

Conversation

@tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Oct 29, 2025

  • Align formatting across key functions and classes of backend
  • Fix some docstrings

Signed-off-by: Tom Allsop [email protected]

Change-Id: I303b01a16cf1fefda3563a49a9937423717903a7

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

* Align formatting across key functions and classes of backend
* Fix some docstrings

Signed-off-by: Tom Allsop <[email protected]>

Change-Id: I303b01a16cf1fefda3563a49a9937423717903a7
@tom-arm tom-arm requested a review from digantdesai as a code owner October 29, 2025 16:00
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15443

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 5 Unrelated Failures

As of commit 7168441 with merge base 94ce147 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Oct 29, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 30, 2025

  1. Fails in test-arm-backedn (xxx)

FAILED backends/arm/test/models/test_conformer.py::test_conformer_tosa_INT - AssertionError: Output 0 does not match reference output.
Given atol: 0.4, rtol: 0.4.
Output tensor shape: torch.Size([10, 93, 16]), dtype: torch.float32
Difference: max: 0.5163156986236572, abs: 0.5163156986236572, mean abs error: 0.019371302803397498.
-- Model vs. Reference --
Numel: 14880, 14880
Median: 0.0, 0.0
Mean: -0.0003138647925469183, -9.620993608428586e-05
Max: 2.9570810794830322, 2.933612108230591
Min: -2.9805498123168945, -2.9805498123168945
= 1 failed, 92 passed, 34 skipped, 13 xfailed, 174 warnings in 1303.03s (0:21:43) =

  1. And test-mcu-models
    This is probably fixed with a rebase, Ill retrigger the job

@zingo zingo merged commit aa21a49 into pytorch:main Oct 30, 2025
292 of 298 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants