Slightly improving 4 bit mat mul performance through better engage ALU pipes by splitting uint to float conversion operation. #15447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15447
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4745c30 with merge base c230e94 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85779855. |
trivedivivek
added
the
release notes: vulkan
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
9db3ed8 to
35be9f2
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
35be9f2 to
88efba0
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
88efba0 to
ff1b33a
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 30, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Differential Revision: D85779855
SS-JIA
approved these changes
Oct 30, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
ff1b33a to
22f63f2
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
22f63f2 to
5639672
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
5639672 to
484eea6
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
484eea6 to
3dd5453
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
3dd5453 to
5d5f0cc
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Oct 31, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
5d5f0cc to
4b3acd1
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 1, 2025
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
4b3acd1 to
0871896
Compare
…U pipes by splitting uint to float conversion operation. (pytorch#15447) Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the `uint` to `float` conversion operation. Reviewed By: SS-JIA Differential Revision: D85779855
trivedivivek
force-pushed
the
export-D85779855
branch
from
0871896 to
4745c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff makes a slight improvement to the performance of 4-bit matrix multiplication by better utilizing the ALU pipes. This is achieved by splitting the
uinttofloatconversion operation.Differential Revision: D85779855