Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

Summary

A minor refactor on HF LLM model UT, so it is easier to maintain

Test plan

UT pass

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15542

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 6 Unrelated Failures

As of commit ea5a454 with merge base 993254c (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai
Copy link
Contributor

cccclai commented Nov 4, 2025

There are still some failing jobs..

@winskuo-quic
Copy link
Collaborator Author

There are still some failing jobs..

Thanks for reviewing the PR.
I double checked the failed tests, and it seems not directly related to this PR. Could you confirm? Thanks

@cccclai
Copy link
Contributor

cccclai commented Nov 5, 2025

Can you rebase? Just would like to double check

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/trigger_ci branch from d6cc780 to ea5a454 Compare November 5, 2025 08:23
@winskuo-quic
Copy link
Collaborator Author

Can you rebase? Just would like to double check

Just rebased. Could you also help trigger the nightly CI? Thanks

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@cccclai cccclai merged commit ac57fde into pytorch:main Nov 6, 2025
324 of 331 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
### Summary
A minor refactor on HF LLM model UT, so it is easier to maintain
### Test plan
UT pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants