Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Nov 4, 2025

In certain cases, avg_pool2d becomes a mean after lowering to edge. When this happens, the meandim decomposition pass is not triggered until the backend preprocess pipeline. To work properly, the pass needs to insert q-dq pairs manually when this happens.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

In certain cases, avg_pool2d becomes a mean after lowering
to edge. When this happens, the meandim decomposition pass
is not triggered until the backend preprocess pipeline. To
work properly, the pass needs to insert q-dq pairs manually
when this happens.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I5c7053d4aabdf90a71ed5a0c95180ddffd8f73e7
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15558

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 9ddda33 with merge base bde6b11 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 4, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@zingo zingo merged commit 11ff521 into pytorch:main Nov 5, 2025
534 of 559 checks passed
abhinaykukkadapu pushed a commit to abhinaykukkadapu/executorch that referenced this pull request Nov 6, 2025
…#15558)

In certain cases, avg_pool2d becomes a mean after lowering to edge. When
this happens, the meandim decomposition pass is not triggered until the
backend preprocess pipeline. To work properly, the pass needs to insert
q-dq pairs manually when this happens.

Signed-off-by: Erik Lundell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants