Skip to content

Conversation

@tanvirislam-meta
Copy link
Contributor

Fixed issues with reactive sizing of banners and updated nav menu for mobile/reactive rendering.

Summary

The nav bar didn't have any title for reactive rendering,
Screenshot 2025-11-04 at 10 19 41 AM
Screenshot 2025-11-04 at 10 21 01 AM

updated reactive rendering to include search and title.

Screenshot 2025-11-04 at 10 22 15 AM

Updated the menu hamburger to be left aligned same as the menu and fixed multimodal example API window for that was being clipped.

Test plan

Manually tested multiple screen resolutions including mobile screen sizes for appropriate rendering.

Fixed issues with reactive sizing of banners and updated nav menu for mobile/reactive rendering.
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15566

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 50 Pending

As of commit f50ab2a with merge base be8b775 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes responsive rendering issues on the ExecuTorch website, specifically addressing mobile navigation and banner sizing problems. The changes ensure the navigation bar displays properly at various screen sizes with an improved hamburger menu implementation and refined responsive breakpoints.

  • Renamed .logo class to .nav-logo for improved semantic clarity
  • Reorganized responsive media queries with new breakpoints (1024px, 650px, 400px) for better mobile rendering
  • Repositioned hamburger menu button and added "Overview" navigation item for mobile views
  • Changed multimodal API container from CSS Grid to Flexbox to prevent content clipping

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
website/style.css Updated navigation class names, reorganized responsive breakpoints, refined banner and logo sizing for various screen widths
website/index.html Restructured navigation HTML with repositioned hamburger button, added overview link, changed multimodal container to flexbox
Comments suppressed due to low confidence (1)

website/style.css:1

  • The .nav-links mobile menu styles at lines 1177-1224 are duplicating styles already defined in the 1024px breakpoint (lines 1041-1076). This creates maintenance overhead. Consider removing this duplication since the 1024px breakpoint will cascade down to smaller screens.
/* Font Faces */

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1038 to +1043
.nav-links {
display: none;
}
.title_banner-logo {
.nav-links {
display: none;
flex-direction: column;
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate .nav-links selector with conflicting styles. Lines 1038-1040 set only display: none, while lines 1041-1055 define the complete mobile menu styles. Remove the duplicate at lines 1038-1040 as it's redundant and makes the code harder to maintain.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link

Copilot AI commented Nov 17, 2025

@mergennachin I've opened a new pull request, #15850, to work on those changes. Once the pull request is ready, I'll request review from you.

@mergennachin mergennachin merged commit 8e33788 into main Nov 17, 2025
136 of 155 checks passed
@mergennachin mergennachin deleted the tanvir-dev branch November 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants