-
Notifications
You must be signed in to change notification settings - Fork 753
Fixes for reactive rendering of webpage #15566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed issues with reactive sizing of banners and updated nav menu for mobile/reactive rendering.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15566
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 50 PendingAs of commit f50ab2a with merge base be8b775 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes responsive rendering issues on the ExecuTorch website, specifically addressing mobile navigation and banner sizing problems. The changes ensure the navigation bar displays properly at various screen sizes with an improved hamburger menu implementation and refined responsive breakpoints.
- Renamed
.logoclass to.nav-logofor improved semantic clarity - Reorganized responsive media queries with new breakpoints (1024px, 650px, 400px) for better mobile rendering
- Repositioned hamburger menu button and added "Overview" navigation item for mobile views
- Changed multimodal API container from CSS Grid to Flexbox to prevent content clipping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/style.css | Updated navigation class names, reorganized responsive breakpoints, refined banner and logo sizing for various screen widths |
| website/index.html | Restructured navigation HTML with repositioned hamburger button, added overview link, changed multimodal container to flexbox |
Comments suppressed due to low confidence (1)
website/style.css:1
- The
.nav-linksmobile menu styles at lines 1177-1224 are duplicating styles already defined in the 1024px breakpoint (lines 1041-1076). This creates maintenance overhead. Consider removing this duplication since the 1024px breakpoint will cascade down to smaller screens.
/* Font Faces */
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .nav-links { | ||
| display: none; | ||
| } | ||
| .title_banner-logo { | ||
| .nav-links { | ||
| display: none; | ||
| flex-direction: column; |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate .nav-links selector with conflicting styles. Lines 1038-1040 set only display: none, while lines 1041-1055 define the complete mobile menu styles. Remove the duplicate at lines 1038-1040 as it's redundant and makes the code harder to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
|
@mergennachin I've opened a new pull request, #15850, to work on those changes. Once the pull request is ready, I'll request review from you. |
Fixed issues with reactive sizing of banners and updated nav menu for mobile/reactive rendering.
Summary
The nav bar didn't have any title for reactive rendering,


updated reactive rendering to include search and title.
Updated the menu hamburger to be left aligned same as the menu and fixed multimodal example API window for that was being clipped.
Test plan
Manually tested multiple screen resolutions including mobile screen sizes for appropriate rendering.