Arm backend: Sort passes in _tosa_pipeline into blocks #15637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15637
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 3 Unrelated FailuresAs of commit 7df244d with merge base 80c9040 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Contributor
|
Feel free to add me as reviewer. @digantdesai is OOO. |
The passes listed in `ArmPassManager._tosa_pipeline` can feel a bit arbitrary because there is no clearly intended structure or pattern being applied there. Restructure the list into clearly labelled blocks to make the code easier to read and maintain. Signed-off-by: Martin Lindström <[email protected]> Change-Id: Iadf37cda2c7a88cad80bf363062d38d492206be7
martinlsm
force-pushed
the
marlin-sort-passes
branch
from
ba79dc1 to
7df244d
Compare
zingo
approved these changes
Nov 7, 2025
Collaborator
|
Fails are unrelated |
Collaborator
|
All changes are within the same file no buck2 build file should be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passes listed in
ArmPassManager._tosa_pipelinecan feel a bit arbitrary because there is no clearly intended structure or pattern being applied there. Restructure the list into clearly labelled blocks to make the code easier to read and maintain.cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai