Skip to content

Conversation

@eigen-k
Copy link
Contributor

@eigen-k eigen-k commented Dec 2, 2025

Differential Revision: D88109862

@eigen-k eigen-k requested a review from kimishpatel as a code owner December 2, 2025 18:20
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16048

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 352f4a4 with merge base c3a53f3 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 2, 2025

@eigen-k has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88109862.

eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 2, 2025
…rted. (pytorch#16048)

Summary: Pull Request resolved: pytorch#16048

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 2, 2025
…rted. (pytorch#16048)

Summary: Pull Request resolved: pytorch#16048

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 2, 2025
…rted. (pytorch#16048)

Summary: Pull Request resolved: pytorch#16048

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 3, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 4, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 4, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 5, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 5, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 5, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 5, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 9, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 9, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
@eigen-k eigen-k force-pushed the export-D88109862 branch 2 times, most recently from 8d08b43 to 258ea24 Compare December 9, 2025 22:07
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 9, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
@eigen-k eigen-k added the release notes: none Do not include this in the release notes label Dec 10, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
eigen-k added a commit to eigen-k/executorch that referenced this pull request Dec 10, 2025
…rted (pytorch#16048)

Summary:

This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module.

Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic.

Reviewed By: DrJessop

Differential Revision: D88109862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants