-
Notifications
You must be signed in to change notification settings - Fork 752
Replace duplicated RemoveCloneOpPass with RemoveCloneOpsTransformImported. #16048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eigen-k
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
eigen-k:export-D88109862
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16048
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 352f4a4 with merge base c3a53f3 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
e96089f to
66d94b2
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
…rted. (pytorch#16048) Summary: Pull Request resolved: pytorch#16048 Differential Revision: D88109862
66d94b2 to
555e25e
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 3, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Differential Revision: D88109862
DrJessop
approved these changes
Dec 3, 2025
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
555e25e to
4df0b32
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
4df0b32 to
881efcd
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
881efcd to
a4e8b4f
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
a4e8b4f to
33fa90a
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 9, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 9, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
8d08b43 to
258ea24
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 9, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
258ea24 to
352f4a4
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 10, 2025
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
release notes: none
Do not include this in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D88109862