Move remove passes to iterative section. #16049
Open
+2
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16049
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit b762ac7 with merge base ee236cb ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
eigen-k
force-pushed
the
export-D88109852
branch
from
9421531 to
ba0d75c
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 2, 2025
Summary: Pull Request resolved: pytorch#16049 Differential Revision: D88109852
eigen-k
force-pushed
the
export-D88109852
branch
from
ba0d75c to
0cd2184
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 4, 2025
Summary: This change reorganizes the pass execution order by moving the remove passes (clone removal, permute removal, etc.) into the iterative section of the pass manager. Previously, these passes were executed in a single-shot manner. By moving them to the iterative section, the pass manager can now run these optimization passes repeatedly until a fixed point is reached, where no further optimizations can be applied. This is important because removing one operation may enable additional removal opportunities that weren't visible before. Differential Revision: D88109852
eigen-k
force-pushed
the
export-D88109852
branch
2 times, most recently
from
2c8e13a to
391da00
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change reorganizes the pass execution order by moving the remove passes (clone removal, permute removal, etc.) into the iterative section of the pass manager. Previously, these passes were executed in a single-shot manner. By moving them to the iterative section, the pass manager can now run these optimization passes repeatedly until a fixed point is reached, where no further optimizations can be applied. This is important because removing one operation may enable additional removal opportunities that weren't visible before. Differential Revision: D88109852
eigen-k
force-pushed
the
export-D88109852
branch
from
391da00 to
37998d3
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Dec 5, 2025
Summary: This change reorganizes the pass execution order by moving the remove passes (clone removal, permute removal, etc.) into the iterative section of the pass manager. Previously, these passes were executed in a single-shot manner. By moving them to the iterative section, the pass manager can now run these optimization passes repeatedly until a fixed point is reached, where no further optimizations can be applied. This is important because removing one operation may enable additional removal opportunities that weren't visible before. Differential Revision: D88109852
…rted (pytorch#16048) Summary: This change eliminates code duplication by replacing the local `RemoveCloneOpPass` implementation with the imported `RemoveCloneOpsTransformImported` from the executorch transforms module. Previously, there were multiple implementations of the clone removal pass scattered across the codebase. This consolidation improves maintainability by ensuring a single source of truth for the clone removal optimization logic. Reviewed By: DrJessop Differential Revision: D88109862
Summary: This change reorganizes the pass execution order by moving the remove passes (clone removal, permute removal, etc.) into the iterative section of the pass manager. Previously, these passes were executed in a single-shot manner. By moving them to the iterative section, the pass manager can now run these optimization passes repeatedly until a fixed point is reached, where no further optimizations can be applied. This is important because removing one operation may enable additional removal opportunities that weren't visible before. Reviewed By: hsharma35 Differential Revision: D88109852
eigen-k
force-pushed
the
export-D88109852
branch
from
37998d3 to
b762ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D88109852