Skip to content

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Dec 3, 2025

Summary: Was using buck-based loading of quantized decomposed in ref_implementations which isn't CMake-compatible. This fixes that approach.

Differential Revision: D88303133

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16066

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6d4869d with merge base e74f1d3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 3, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88303133.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Dec 4, 2025
Summary:

Was using buck-based loading of quantized decomposed in ref_implementations which isn't CMake-compatible. This fixes that approach.

Reviewed By: zonglinpeng

Differential Revision: D88303133
Summary:

Was using buck-based loading of quantized decomposed in ref_implementations which isn't CMake-compatible. This fixes that approach.

Reviewed By: zonglinpeng

Differential Revision: D88303133
@meta-codesync meta-codesync bot merged commit 2d1f181 into pytorch:main Dec 4, 2025
142 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants