Skip to content

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Core #16474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 2 commits into from
Jan 9, 2026
+20 −104
Merged

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Core #16474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca68938
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Core
GregoryComer Jan 6, 2026
ffa8fa6
Update on "[executorch] Remove EXECUTORCH_CLIENTS visibility gating -…
GregoryComer Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions runtime/core/exec_aten/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ def define_common_targets():
name = "lib" + aten_suffix,
exported_headers = ["exec_aten.h"],
exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = ["//executorch/runtime/core:tensor_shape_dynamism"] + ([] if aten_mode else ["//executorch/runtime/core/portable_type:portable_type"]),
exported_external_deps = ["libtorch"] if aten_mode else [],
)
21 changes: 1 addition & 20 deletions runtime/core/exec_aten/testing_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,7 @@ def define_common_targets():
"tensor_util.h",
"tensor_factory.h",
],
visibility = [
# Be strict with the visibility so that operator implementations
# under //executorch/kernels/... can't depend on this test-only
# target. It's ok to add any //executorch/*/test/... path to this
# list.
"//executorch/runtime/core/exec_aten/util/test/...",
"//executorch/runtime/core/exec_aten/testing_util/test/...",
"//executorch/runtime/core/portable_type/test/...",
"//executorch/kernels/prim_ops/test/...",
"//executorch/kernels/portable/test/...",
"//executorch/kernels/portable/cpu/util/test/...",
"//executorch/kernels/quantized/test/...",
"//executorch/kernels/optimized/test/...",
"//executorch/kernels/test/...",
"//executorch/kernels/fb/custom_ops/...",
"//executorch/runtime/core/test/...",
"//executorch/test/...",
"//executorch/extension/kernel_util/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
compiler_flags = ["-Wno-unneeded-internal-declaration"],
exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [],
exported_deps = [
Expand Down
25 changes: 5 additions & 20 deletions runtime/core/exec_aten/util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ def define_common_targets():
exported_headers = [
"scalar_type_util.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_preprocessor_flags = exported_preprocessor_flags_,
exported_deps = exported_deps_,
exported_external_deps = ["libtorch"] if aten_mode else [],
Expand All @@ -42,10 +39,7 @@ def define_common_targets():
"//executorch/runtime/core:core",
"//executorch/runtime/core/portable_type/c10/c10:c10",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [],
)

Expand All @@ -55,10 +49,7 @@ def define_common_targets():
exported_headers = [
"tensor_util.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [],
exported_deps = [
":tensor_dimension_limit",
Expand All @@ -84,17 +75,11 @@ def define_common_targets():
"//executorch/runtime/core/exec_aten/util:tensor_dimension_limit",
],
exported_headers = ["tensor_shape_to_c_string.h"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

runtime.cxx_library(
name = "tensor_dimension_limit",
exported_headers = ["tensor_dimension_limit.h"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
16 changes: 3 additions & 13 deletions runtime/core/portable_type/c10/c10/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,7 @@ def define_common_targets():
runtime.cxx_library(
name = "aten_headers_for_executorch",
srcs = [],
visibility = [
"//executorch/kernels/optimized/...",
"//executorch/kernels/portable/cpu/util/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
# select() on ovr_config//runtime:fbcode does not work
# properly in all cases. I have seen
# //xplat/executorch/runtime/core/portable_type/c10/c10:aten_headers_for_executorch
Expand Down Expand Up @@ -124,10 +120,7 @@ def define_common_targets():
"-DC10_USE_GLOG",
"-DC10_USE_MINIMAL_GLOG",
]),
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core/portable_type/c10/torch/headeronly:torch_headeronly",
] + select({
Expand All @@ -142,8 +135,5 @@ def define_common_targets():
runtime.cxx_library(
name = "c10",
exported_deps = [":aten_headers_for_executorch"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
25 changes: 5 additions & 20 deletions runtime/core/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ def define_common_targets():
"result.h",
"span.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_preprocessor_flags = get_core_flags(),
exported_deps = [
"//executorch/runtime/core/portable_type/c10/c10:c10",
Expand Down Expand Up @@ -82,10 +79,7 @@ def define_common_targets():
":core",
"//executorch/runtime/core/portable_type/c10/c10:c10",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

for aten_mode in get_aten_mode_options():
Expand All @@ -96,10 +90,7 @@ def define_common_targets():
"evalue.h",
],
srcs = ["evalue.cpp"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":core",
":tag",
Expand All @@ -114,10 +105,7 @@ def define_common_targets():
"event_tracer_hooks.h",
"event_tracer_hooks_delegate.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_preprocessor_flags = get_event_tracer_flags() + get_sdk_flags(),
exported_deps = [
"//executorch/runtime/platform:platform",
Expand All @@ -130,10 +118,7 @@ def define_common_targets():
exported_headers = [
"named_data_map.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":tensor_layout" + aten_suffix,
"//executorch/runtime/core/exec_aten:lib" + aten_suffix,
Expand Down
5 changes: 1 addition & 4 deletions runtime/core/testing_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ def define_common_targets():
exported_headers = [
"error_matchers.h",
],
visibility = [
"//executorch/runtime/core/testing_util/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_external_deps = [
"gmock",
],
Expand Down
15 changes: 3 additions & 12 deletions runtime/platform/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,7 @@ def define_common_targets():
":compiler",
":platform_private",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
# WARNING: using a deprecated API to avoid being built into a shared
# library. In the case of dynamically loading so library we don't want
# it to depend on other so libraries because that way we have to
Expand All @@ -110,10 +107,7 @@ def define_common_targets():
"ovr_config//os:macos": ["-DET_USE_LIBDL"],
},
),
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

# Common compiler directives such as 'unlikely' or 'deprecated'
Expand All @@ -122,8 +116,5 @@ def define_common_targets():
exported_headers = [
"compiler.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
12 changes: 1 addition & 11 deletions shim_et/xplat/executorch/build/runtime_wrapper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,7 @@ def _patch_kwargs_common(kwargs):
"""
env.remove_unsupported_kwargs(kwargs)

# Be careful about dependencies on executorch targets for now, so that we
# don't pick up unexpected clients while things are still in flux.
if not kwargs.pop("_is_external_target", False):
for target in kwargs.get("visibility", []):
if not (target == "PUBLIC" or target.startswith("//executorch") or target.startswith("//pytorch/tokenizers") or target.startswith("@")):
fail("Please manage all external visibility using the " +
"EXECUTORCH_CLIENTS list in " +
"//executorch/build/fb/clients.bzl. " +
"Found external visibility target \"{}\".".format(target))
else:
kwargs.pop("_is_external_target", None)
kwargs.pop("_is_external_target", False)

# Convert `[exported_]external_deps` entries into real deps if necessary.
_resolve_external_deps(kwargs)
Expand Down
Loading