llm release with logging #16496
llm release with logging #16496
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16496
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit 2dcd8dc with merge base 3090486 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
JacobSzwejbka
requested review from
kirklandsign and
larryliu0820
as code owners
This PR needs a
|
| ] | ||
| }, | ||
| { | ||
| "name": "llm-release-logging", |
There was a problem hiding this comment.
what's the difference between this and the llm-release-logging above?
There was a problem hiding this comment.
The other stuff lets you do
cmake --workflow --preset llm-release-logging
vs
cmake --preset llm-release-logging
cmake --build --preset llm-release-logging-install
| } | ||
| }, | ||
| { | ||
| "name": "llm-release-logging", |
There was a problem hiding this comment.
can we just concentrate all things inside debug mode? Now we have too much different modes
There was a problem hiding this comment.
Right now we have logging coupled with optimizations (debug mode). Since we are for some reason using ET logs to report useful step information to the user in the examples binaries it would be useful to have these be independent decisions. Debug mode is at least twice as slow as release for cpu portable ops
No description provided.