Skip to content

Conversation

@DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Jan 7, 2026

Summary:
In previous approach, faketensor shape propagation converted constant to fake tensor, which meant no data for visualization.

Now, value encoded as scalar arg in graph, and can compute output metadata without needing actual tensor data. If downstream op needs value, can trace back through graph and see it came from full(0) - preserved in graph structure, not in tensor data.

Reviewed By: skrtskrtfb

Differential Revision: D90275311

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16497

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ecdb913 with merge base 3090486 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 7, 2026

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90275311.

Summary:
In previous approach, faketensor shape propagation converted constant to fake tensor, which meant no data for visualization.

Now, value encoded as scalar arg in graph, and can compute output metadata without needing actual tensor data. If downstream op needs value, can trace back through graph and see it came from full(0) - preserved in graph structure, not in tensor data.

Reviewed By: skrtskrtfb

Differential Revision: D90275311
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit a1076af into pytorch:main Jan 8, 2026
141 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants